Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MGLNetworkConfiguration #57

Closed
georgbachmann opened this issue Jan 28, 2021 · 2 comments
Closed

Missing MGLNetworkConfiguration #57

georgbachmann opened this issue Jan 28, 2021 · 2 comments
Assignees

Comments

@georgbachmann
Copy link

New Feature

The old version of the Mapbox iOS SDK had MGLNetworkConfiguration. There I could set a delegate and therefore intercept API calls. We need something similar again for the new version.

Why

We used this feature, to implement our own Offline-Map handling. The problem with the default offline-map handling for us was that it wasn't 1. working in the background, 2. very CPU intensive and 3. quite slow.
That's why we went ahead and pre-packed regions for the user. By intercepting the network calls, we were able to provide those tiles ourselves.
We use the same on Android and iOS, and the Android version seems to have even improved support for that:
https://docs.mapbox.com/android/beta/maps/guides/migrate-to-v10/#example-replace-modular-http-stack

For us this is an absolute must as we already build our whole infrastructure on that.

@julianrex
Copy link
Contributor

@georgbachmann thanks for posting and for trying out the beta.

It is possible to replace the HTTP stack on iOS, similar to the process on Android. We have updated the migration guide with a similar snippet: https://docs.mapbox.com/ios/beta/maps/guides/migrate-to-v10/#example-replaceable-http-stack

I'm going to close this issue as answered, but please open another feature request if there are features of the default network handling that you would like to see added or amended.

@georgbachmann
Copy link
Author

Wohoooo... that's great news! Thank you @julianrex ! I'll have a look at what's possible with the HttpServiceInterface but looks promising from what I can see in the documentation!

persidskiy pushed a commit that referenced this issue Feb 24, 2023
* Send unique report per each run measurement (#1633)

* Prevent view annotation being shown erroneously after options update (#1627)

* Add an example animating a view annotation along a route line (#1639)

* Fix unit tests on iPhone mini 12/13 (#1643)

* Add generated Annotation Manager Tests (#1617)

* Add Initial Annotation Manager Tests

* Add generated tests for all annotation managers

* Resolve swiftlint issues

* Reduce location provider heading orientation update frequency (#1618)

* Increase timeout for view annotation animation example (#1645)

* Expose list of added view annotations (#1621)

* Fix view annotation animation example crashing on iOS 13 (#1653)

* Delay view annotation animation start

* Fiddle with CircleCI

* Delaying animation start

* Fix build errors

* Tangible animation delay + window scene link

* Disable animation altogether

* Finish the example right after setting it up

* Throw away unneeded tests

* Remove all setup

* Uncomment source

* Uncomment layer

* Uncomment view annotations

* Wait for 21 sec

* Wait for 1 sec

* Run animation with 3s delay

* Start the animation immediatedly

* Common mode for display link

* Default mode for display link

* Revert test setup

* Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652)

* Support 120Hz in DebugMap example (#1647)

* Enable 120Hz on supported screens in DebugMap example

* Drop pre-Xcode 13 compilation conditions

* Fix swiftlint warning

* Bump version to 10.9.0 (#1656)

* Use different set of devices for Examples tests (#1660)

* Feature/fix warnings (#1661)

* Ignore deprecated examples in Release config

* Fix warnings

* Update the latest Xcode

* Improve swiftlint configuration

* Store correct artifacts for Examples Tests

* Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650)

* Improve reduced accuracy authorization location indicator behavior while zooming (#1644)

* Use iPhone 13 Pro for individul device tests (#1664)

* Add Cluster Support for Point Annotation Managers (#1651)

* Enable clustering of point annotations, create cluster options, add example and tests

* Add first tests for clustering

* Add tests and documentation

* Update Project file paths

* Add new function definition to allowlist

* Improve example, add better documentation

* Add and fix unit tests

* Update access level and fix swiftlint

* Respond to PR comments

* Add changelog entry

* Jazzy docs

* Remove colorLevels in favor of circleColorExpression

* Update destoy to include the added cluster layers

* Reorganize cluster options, expand example

* Adjust documentation

* Bugfix/mapsios 328 better handling set style result observers (#1665)

* Add test case to verify loadStyle handler is invoked exactly once
* Cancel loadStyle observers on first expected events received

* Update CHANGELOG.md (#1667)

* Disable indexing on CI machines (#1672)

* Remove outdated performance baseline (#1671)

* Remove outdates performance baseline

* Remove Baseline related code from XCParty

* Update XCParty to support Xcode 14

* Feature/mapsios 367 frame view annotations (#1634)

* API to get camera options to fit a list of view annotations.

* Run MetricsV2 tests when CIRCLECI_TAG is set (#1674)

* Remove ornament position deprecation (#1676)

Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Co-authored-by: Mai Mai <mai.mai@mapbox.com>
Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants