Prevent view annotation being shown erroneously after options update #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evil159
force-pushed
the
rl/MAPSIOS-350-view-annotation-update-visibility-fix
branch
from
3502161
to
5ee9477
Compare
OdNairy
reviewed
Oct 11, 2022
| expectedHiddenByView[view] = isHidden | ||
| viewsById[id]?.isHidden = isHidden | ||
|
|
||
| if let visible = options.visible, visible == false { |
There was a problem hiding this comment.
It is the same, isn't it?
Suggested change
| if let visible = options.visible, visible == false { | |
| if visible == false { |
There was a problem hiding this comment.
And if it's not, can we add some tests to catch the corner case, please? This Optional logic is really tricky 😅
There was a problem hiding this comment.
Same thing indeed, not sure why I went with more verbose syntax
OdNairy
approved these changes
Oct 12, 2022
evil159
deleted the
rl/MAPSIOS-350-view-annotation-update-visibility-fix
branch
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) * Use iPhone 13 Pro for individul device tests (#1664) * Add Cluster Support for Point Annotation Managers (#1651) * Enable clustering of point annotations, create cluster options, add example and tests * Add first tests for clustering * Add tests and documentation * Update Project file paths * Add new function definition to allowlist * Improve example, add better documentation * Add and fix unit tests * Update access level and fix swiftlint * Respond to PR comments * Add changelog entry * Jazzy docs * Remove colorLevels in favor of circleColorExpression * Update destoy to include the added cluster layers * Reorganize cluster options, expand example * Adjust documentation * Bugfix/mapsios 328 better handling set style result observers (#1665) * Add test case to verify loadStyle handler is invoked exactly once * Cancel loadStyle observers on first expected events received * Update CHANGELOG.md (#1667) * Disable indexing on CI machines (#1672) * Remove outdated performance baseline (#1671) * Remove outdates performance baseline * Remove Baseline related code from XCParty * Update XCParty to support Xcode 14 * Feature/mapsios 367 frame view annotations (#1634) * API to get camera options to fit a list of view annotations. * Run MetricsV2 tests when CIRCLECI_TAG is set (#1674) * Remove ornament position deprecation (#1676) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) * Use iPhone 13 Pro for individul device tests (#1664) * Add Cluster Support for Point Annotation Managers (#1651) * Enable clustering of point annotations, create cluster options, add example and tests * Add first tests for clustering * Add tests and documentation * Update Project file paths * Add new function definition to allowlist * Improve example, add better documentation * Add and fix unit tests * Update access level and fix swiftlint * Respond to PR comments * Add changelog entry * Jazzy docs * Remove colorLevels in favor of circleColorExpression * Update destoy to include the added cluster layers * Reorganize cluster options, expand example * Adjust documentation * Bugfix/mapsios 328 better handling set style result observers (#1665) * Add test case to verify loadStyle handler is invoked exactly once * Cancel loadStyle observers on first expected events received * Update CHANGELOG.md (#1667) * Disable indexing on CI machines (#1672) * Remove outdated performance baseline (#1671) * Remove outdates performance baseline * Remove Baseline related code from XCParty * Update XCParty to support Xcode 14 * Feature/mapsios 367 frame view annotations (#1634) * API to get camera options to fit a list of view annotations. * Run MetricsV2 tests when CIRCLECI_TAG is set (#1674) * Remove ornament position deprecation (#1676) * Prevent map from being rendered on background (#1675) * Bump CoreMaps to 10.10.0-beta.1 and Common to 23.2.0-beta.1 (#1680) * Print ABI report on module loading failure (#1682) * Support `isDraggable` and `isSelected` for annotations (#1659) * working branch * wip * isDraggable work in progress * removing debug view controller from commit * fixing debug view controller * removing unnecessarily added commits * Delete style.json * Update CircleAnnotationExample.swift * Delete Contents.json * removing images * Update AnnotationOrchestrator.swift * Update AnnotationOrchestrator.swift * removing used variables * running swiftlint * removing unnecessary files isDraggable work in progress wip removing debug view controller from commit fixing debug view controller removing unnecessarily added commits removing images Delete style.json Update CircleAnnotationExample.swift Delete Contents.json Update AnnotationOrchestrator.swift Update AnnotationOrchestrator.swift removing used variables running swiftlint * adding tests and changelog entry * applied changes to annotation generated files * make formatting changes to annotation generated file * updating tests * updating annotation manager tests * fixing longPressGestureRecognizer in annotation manager * added handle drag test * resolving issues with annotation generation file * resolving swiftlint errors * resolving issues with failing tests * removing annotation tests * making requested changes * implementing suggestions and resolving issue with inner polygon * replaced try? with do-catch * updating tests to resolve errors * making requested changes * removing extra space in annotation files * resolving syntax errors in annotation managers generation file * Draggable annotations review suggestions (#1678) * Replace MoveDistanceObject with MapboxLongPressGestureRecognizer * Use drag layer/source identifiers unique per annotation manager to avoid collisions * Call didDetectTappedAnnotations after updating isSelected status Copy the existing layer as the drag layer Pass feature of annotation being dragged as a source data for drag source * resolving failing tests * resolving swiftlint errors * Revert "resolving swiftlint errors" This reverts commit bab263b. * testing swiflint resolution * removing whitespace * Update Sources/MapboxMaps/Annotations/Generated/PointAnnotationManager.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Update Apps/Examples/Examples/All Examples/Annotations/CustomPointAnnotationExample.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Address review feedback * Fix unit tests * modifying code so tapped annotations contains newly selected annotation * Revert "modifying code so tapped annotations contains newly selected annotation" This reverts commit ca35b5f. * fixing tapped annotation behavior and unit tests * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> * Update Apps/Examples/Examples/All Examples/Annotations/PolygonAnnotationExample.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/OffsetGeometryCalculator.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * making requested changes * Remove ornament position deprecation (#1676) * AnnotationManager Tests (#1683) * adding annotation manager tests Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Add API to enable/disable render world copies (#1684) * Add UI test to grant location permission before running examples tests (#1685) * New API to load custom style JSON on the initilization of MapView (#1686) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) * Use iPhone 13 Pro for individul device tests (#1664) * Add Cluster Support for Point Annotation Managers (#1651) * Enable clustering of point annotations, create cluster options, add example and tests * Add first tests for clustering * Add tests and documentation * Update Project file paths * Add new function definition to allowlist * Improve example, add better documentation * Add and fix unit tests * Update access level and fix swiftlint * Respond to PR comments * Add changelog entry * Jazzy docs * Remove colorLevels in favor of circleColorExpression * Update destoy to include the added cluster layers * Reorganize cluster options, expand example * Adjust documentation * Bugfix/mapsios 328 better handling set style result observers (#1665) * Add test case to verify loadStyle handler is invoked exactly once * Cancel loadStyle observers on first expected events received * Update CHANGELOG.md (#1667) * Disable indexing on CI machines (#1672) * Remove outdated performance baseline (#1671) * Remove outdates performance baseline * Remove Baseline related code from XCParty * Update XCParty to support Xcode 14 * Feature/mapsios 367 frame view annotations (#1634) * API to get camera options to fit a list of view annotations. * Run MetricsV2 tests when CIRCLECI_TAG is set (#1674) * Remove ornament position deprecation (#1676) * Prevent map from being rendered on background (#1675) * Bump CoreMaps to 10.10.0-beta.1 and Common to 23.2.0-beta.1 (#1680) * Print ABI report on module loading failure (#1682) * Support `isDraggable` and `isSelected` for annotations (#1659) * working branch * wip * isDraggable work in progress * removing debug view controller from commit * fixing debug view controller * removing unnecessarily added commits * Delete style.json * Update CircleAnnotationExample.swift * Delete Contents.json * removing images * Update AnnotationOrchestrator.swift * Update AnnotationOrchestrator.swift * removing used variables * running swiftlint * removing unnecessary files isDraggable work in progress wip removing debug view controller from commit fixing debug view controller removing unnecessarily added commits removing images Delete style.json Update CircleAnnotationExample.swift Delete Contents.json Update AnnotationOrchestrator.swift Update AnnotationOrchestrator.swift removing used variables running swiftlint * adding tests and changelog entry * applied changes to annotation generated files * make formatting changes to annotation generated file * updating tests * updating annotation manager tests * fixing longPressGestureRecognizer in annotation manager * added handle drag test * resolving issues with annotation generation file * resolving swiftlint errors * resolving issues with failing tests * removing annotation tests * making requested changes * implementing suggestions and resolving issue with inner polygon * replaced try? with do-catch * updating tests to resolve errors * making requested changes * removing extra space in annotation files * resolving syntax errors in annotation managers generation file * Draggable annotations review suggestions (#1678) * Replace MoveDistanceObject with MapboxLongPressGestureRecognizer * Use drag layer/source identifiers unique per annotation manager to avoid collisions * Call didDetectTappedAnnotations after updating isSelected status Copy the existing layer as the drag layer Pass feature of annotation being dragged as a source data for drag source * resolving failing tests * resolving swiftlint errors * Revert "resolving swiftlint errors" This reverts commit bab263b. * testing swiflint resolution * removing whitespace * Update Sources/MapboxMaps/Annotations/Generated/PointAnnotationManager.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Update Apps/Examples/Examples/All Examples/Annotations/CustomPointAnnotationExample.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Address review feedback * Fix unit tests * modifying code so tapped annotations contains newly selected annotation * Revert "modifying code so tapped annotations contains newly selected annotation" This reverts commit ca35b5f. * fixing tapped annotation behavior and unit tests * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> * Update Apps/Examples/Examples/All Examples/Annotations/PolygonAnnotationExample.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/OffsetGeometryCalculator.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * making requested changes * Remove ornament position deprecation (#1676) * AnnotationManager Tests (#1683) * adding annotation manager tests Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Add API to enable/disable render world copies (#1684) * Add UI test to grant location permission before running examples tests (#1685) * New API to load custom style JSON on the initilization of MapView (#1686) * Bump version to v10.10.0-beta.1 (#1689) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) * Use iPhone 13 Pro for individul device tests (#1664) * Add Cluster Support for Point Annotation Managers (#1651) * Enable clustering of point annotations, create cluster options, add example and tests * Add first tests for clustering * Add tests and documentation * Update Project file paths * Add new function definition to allowlist * Improve example, add better documentation * Add and fix unit tests * Update access level and fix swiftlint * Respond to PR comments * Add changelog entry * Jazzy docs * Remove colorLevels in favor of circleColorExpression * Update destoy to include the added cluster layers * Reorganize cluster options, expand example * Adjust documentation * Bugfix/mapsios 328 better handling set style result observers (#1665) * Add test case to verify loadStyle handler is invoked exactly once * Cancel loadStyle observers on first expected events received * Update CHANGELOG.md (#1667) * Disable indexing on CI machines (#1672) * Remove outdated performance baseline (#1671) * Remove outdates performance baseline * Remove Baseline related code from XCParty * Update XCParty to support Xcode 14 * Feature/mapsios 367 frame view annotations (#1634) * API to get camera options to fit a list of view annotations. * Run MetricsV2 tests when CIRCLECI_TAG is set (#1674) * Remove ornament position deprecation (#1676) * Prevent map from being rendered on background (#1675) * Bump CoreMaps to 10.10.0-beta.1 and Common to 23.2.0-beta.1 (#1680) * Print ABI report on module loading failure (#1682) * Support `isDraggable` and `isSelected` for annotations (#1659) * working branch * wip * isDraggable work in progress * removing debug view controller from commit * fixing debug view controller * removing unnecessarily added commits * Delete style.json * Update CircleAnnotationExample.swift * Delete Contents.json * removing images * Update AnnotationOrchestrator.swift * Update AnnotationOrchestrator.swift * removing used variables * running swiftlint * removing unnecessary files isDraggable work in progress wip removing debug view controller from commit fixing debug view controller removing unnecessarily added commits removing images Delete style.json Update CircleAnnotationExample.swift Delete Contents.json Update AnnotationOrchestrator.swift Update AnnotationOrchestrator.swift removing used variables running swiftlint * adding tests and changelog entry * applied changes to annotation generated files * make formatting changes to annotation generated file * updating tests * updating annotation manager tests * fixing longPressGestureRecognizer in annotation manager * added handle drag test * resolving issues with annotation generation file * resolving swiftlint errors * resolving issues with failing tests * removing annotation tests * making requested changes * implementing suggestions and resolving issue with inner polygon * replaced try? with do-catch * updating tests to resolve errors * making requested changes * removing extra space in annotation files * resolving syntax errors in annotation managers generation file * Draggable annotations review suggestions (#1678) * Replace MoveDistanceObject with MapboxLongPressGestureRecognizer * Use drag layer/source identifiers unique per annotation manager to avoid collisions * Call didDetectTappedAnnotations after updating isSelected status Copy the existing layer as the drag layer Pass feature of annotation being dragged as a source data for drag source * resolving failing tests * resolving swiftlint errors * Revert "resolving swiftlint errors" This reverts commit bab263b. * testing swiflint resolution * removing whitespace * Update Sources/MapboxMaps/Annotations/Generated/PointAnnotationManager.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Update Apps/Examples/Examples/All Examples/Annotations/CustomPointAnnotationExample.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Address review feedback * Fix unit tests * modifying code so tapped annotations contains newly selected annotation * Revert "modifying code so tapped annotations contains newly selected annotation" This reverts commit ca35b5f. * fixing tapped annotation behavior and unit tests * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> * Update Apps/Examples/Examples/All Examples/Annotations/PolygonAnnotationExample.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/OffsetGeometryCalculator.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * making requested changes * Remove ornament position deprecation (#1676) * AnnotationManager Tests (#1683) * adding annotation manager tests Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Add API to enable/disable render world copies (#1684) * Add UI test to grant location permission before running examples tests (#1685) * New API to load custom style JSON on the initilization of MapView (#1686) * Bump version to v10.10.0-beta.1 (#1689) * Add sky layer deprecation docs (#1694) * Add sky layer deprecation docs * Add link to atmosphere * Remove 10s delay as CoreTelemetry does not freeze main thread (#1699) * Update generated code to use latest spec (#1696) * Fix memory leak when viewport is being deallocated while transition is running (#1691) * Add missing changelog entry (#1707) * Update generated code (#1708) * Flush telemetry on MapView deinit (#1700) * Refactoring to use EventsManager init over shared * Add explicit flush on EventsManager deinit (happens on MapView deinit as well) * Send map.load event with queued priority * Some unit tests refactoring * Add iPhone XR iOS 12 to the test device list (#1715) * Expand cluster example to show additional functionality (#1713) * Expand example to include zooming on cluster click * Add documentation details * Fix language support and label localization (#1687) * Change tests to correct expectations, modify implementation * Pull in Nav changes * Port localization approach from nav * Address PR feedback * Expand test coverage * Respond to review, enable passing system Locale * Add additional tests * Clean up implementation, add additional tests * Add changelog entry * Update changelog * Use Test Plans for Examples target to avoid unit tests on CI (#1716) Adding two test plans: - The default includes Examples tests along with UI tests and Maps unit tests - The second test plan ignores unit tests to support running tests on devices (SPM unit tests doesn't have a host app so cannot be run on iOS devices) Fixes for Changelog broken URLs * Resolve issue with simultaneous recognition of tap gesture (#1712) * Support iOS 12 for location permission dialog workaround (#1719) * Support iOS 12 for location permission dialog workaround * Rewrite Accept location UI test in favor of buttons awaitance * Resolve Hans handling on v7 (#1720) Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Kiryl Dzehtsiarenka <kiryl.dzehtsiarenka@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Send unique report per each run measurement (#1633) * Prevent view annotation being shown erroneously after options update (#1627) * Add an example animating a view annotation along a route line (#1639) * Fix unit tests on iPhone mini 12/13 (#1643) * Add generated Annotation Manager Tests (#1617) * Add Initial Annotation Manager Tests * Add generated tests for all annotation managers * Resolve swiftlint issues * Reduce location provider heading orientation update frequency (#1618) * Increase timeout for view annotation animation example (#1645) * Expose list of added view annotations (#1621) * Fix view annotation animation example crashing on iOS 13 (#1653) * Delay view annotation animation start * Fiddle with CircleCI * Delaying animation start * Fix build errors * Tangible animation delay + window scene link * Disable animation altogether * Finish the example right after setting it up * Throw away unneeded tests * Remove all setup * Uncomment source * Uncomment layer * Uncomment view annotations * Wait for 21 sec * Wait for 1 sec * Run animation with 3s delay * Start the animation immediatedly * Common mode for display link * Default mode for display link * Revert test setup * Bump CoreMaps to 10.9.0 MapboxCommon to 23.1.0 (#1652) * Support 120Hz in DebugMap example (#1647) * Enable 120Hz on supported screens in DebugMap example * Drop pre-Xcode 13 compilation conditions * Fix swiftlint warning * Bump version to 10.9.0 (#1656) * Use different set of devices for Examples tests (#1660) * Feature/fix warnings (#1661) * Ignore deprecated examples in Release config * Fix warnings * Update the latest Xcode * Improve swiftlint configuration * Store correct artifacts for Examples Tests * Avoid triggering assertion for the 3D puck layer when returning `allLayerIdentifiers` (#1650) * Improve reduced accuracy authorization location indicator behavior while zooming (#1644) * Use iPhone 13 Pro for individul device tests (#1664) * Add Cluster Support for Point Annotation Managers (#1651) * Enable clustering of point annotations, create cluster options, add example and tests * Add first tests for clustering * Add tests and documentation * Update Project file paths * Add new function definition to allowlist * Improve example, add better documentation * Add and fix unit tests * Update access level and fix swiftlint * Respond to PR comments * Add changelog entry * Jazzy docs * Remove colorLevels in favor of circleColorExpression * Update destoy to include the added cluster layers * Reorganize cluster options, expand example * Adjust documentation * Bugfix/mapsios 328 better handling set style result observers (#1665) * Add test case to verify loadStyle handler is invoked exactly once * Cancel loadStyle observers on first expected events received * Update CHANGELOG.md (#1667) * Disable indexing on CI machines (#1672) * Remove outdated performance baseline (#1671) * Remove outdates performance baseline * Remove Baseline related code from XCParty * Update XCParty to support Xcode 14 * Feature/mapsios 367 frame view annotations (#1634) * API to get camera options to fit a list of view annotations. * Run MetricsV2 tests when CIRCLECI_TAG is set (#1674) * Remove ornament position deprecation (#1676) * Prevent map from being rendered on background (#1675) * Bump CoreMaps to 10.10.0-beta.1 and Common to 23.2.0-beta.1 (#1680) * Print ABI report on module loading failure (#1682) * Support `isDraggable` and `isSelected` for annotations (#1659) * working branch * wip * isDraggable work in progress * removing debug view controller from commit * fixing debug view controller * removing unnecessarily added commits * Delete style.json * Update CircleAnnotationExample.swift * Delete Contents.json * removing images * Update AnnotationOrchestrator.swift * Update AnnotationOrchestrator.swift * removing used variables * running swiftlint * removing unnecessary files isDraggable work in progress wip removing debug view controller from commit fixing debug view controller removing unnecessarily added commits removing images Delete style.json Update CircleAnnotationExample.swift Delete Contents.json Update AnnotationOrchestrator.swift Update AnnotationOrchestrator.swift removing used variables running swiftlint * adding tests and changelog entry * applied changes to annotation generated files * make formatting changes to annotation generated file * updating tests * updating annotation manager tests * fixing longPressGestureRecognizer in annotation manager * added handle drag test * resolving issues with annotation generation file * resolving swiftlint errors * resolving issues with failing tests * removing annotation tests * making requested changes * implementing suggestions and resolving issue with inner polygon * replaced try? with do-catch * updating tests to resolve errors * making requested changes * removing extra space in annotation files * resolving syntax errors in annotation managers generation file * Draggable annotations review suggestions (#1678) * Replace MoveDistanceObject with MapboxLongPressGestureRecognizer * Use drag layer/source identifiers unique per annotation manager to avoid collisions * Call didDetectTappedAnnotations after updating isSelected status Copy the existing layer as the drag layer Pass feature of annotation being dragged as a source data for drag source * resolving failing tests * resolving swiftlint errors * Revert "resolving swiftlint errors" This reverts commit bab263b. * testing swiflint resolution * removing whitespace * Update Sources/MapboxMaps/Annotations/Generated/PointAnnotationManager.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Update Apps/Examples/Examples/All Examples/Annotations/CustomPointAnnotationExample.swift Co-authored-by: Mai Mai <mai.mai@mapbox.com> * Address review feedback * Fix unit tests * modifying code so tapped annotations contains newly selected annotation * Revert "modifying code so tapped annotations contains newly selected annotation" This reverts commit ca35b5f. * fixing tapped annotation behavior and unit tests * Update CHANGELOG.md Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> * Update Apps/Examples/Examples/All Examples/Annotations/PolygonAnnotationExample.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/OffsetGeometryCalculator.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update Sources/MapboxMaps/Annotations/AnnotationOrchestratorImpl.swift Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * making requested changes * Remove ornament position deprecation (#1676) * AnnotationManager Tests (#1683) * adding annotation manager tests Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Add API to enable/disable render world copies (#1684) * Add UI test to grant location permission before running examples tests (#1685) * New API to load custom style JSON on the initilization of MapView (#1686) * Bump version to v10.10.0-beta.1 (#1689) * Add sky layer deprecation docs (#1694) * Add sky layer deprecation docs * Add link to atmosphere * Remove 10s delay as CoreTelemetry does not freeze main thread (#1699) * Update generated code to use latest spec (#1696) * Fix memory leak when viewport is being deallocated while transition is running (#1691) * Add missing changelog entry (#1707) * Update generated code (#1708) * Flush telemetry on MapView deinit (#1700) * Refactoring to use EventsManager init over shared * Add explicit flush on EventsManager deinit (happens on MapView deinit as well) * Send map.load event with queued priority * Some unit tests refactoring * Add iPhone XR iOS 12 to the test device list (#1715) * Expand cluster example to show additional functionality (#1713) * Expand example to include zooming on cluster click * Add documentation details * Fix language support and label localization (#1687) * Change tests to correct expectations, modify implementation * Pull in Nav changes * Port localization approach from nav * Address PR feedback * Expand test coverage * Respond to review, enable passing system Locale * Add additional tests * Clean up implementation, add additional tests * Add changelog entry * Update changelog * Use Test Plans for Examples target to avoid unit tests on CI (#1716) Adding two test plans: - The default includes Examples tests along with UI tests and Maps unit tests - The second test plan ignores unit tests to support running tests on devices (SPM unit tests doesn't have a host app so cannot be run on iOS devices) Fixes for Changelog broken URLs * Resolve issue with simultaneous recognition of tap gesture (#1712) * Support iOS 12 for location permission dialog workaround (#1719) * Support iOS 12 for location permission dialog workaround * Rewrite Accept location UI test in favor of buttons awaitance * Resolve Hans handling on v7 (#1720) * Begin migration to test plans, split unit and integration tests (#1714) * Begin migration to test plans, split unit and integration tests * Add workspace * Move over additional schemes * Update Debugapp TestPlan * Update directories * Undo example changes * A few test plan fixes Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> * Update test checklist item (#1724) * sync swift version (#1726) * Update Swift version in podspec * Update swift version in SPM * Run unit tests on multiple supported iOS versions (#1718) * Bump ci latest Xcode executor to `14.1.0` (#1729) * Update CI xcode image to 14.1 * Fix testplans issue * Update iPhone destination * Force test plan * Bump MapboxCoreMaps to 10.10.0-rc.1 and MapboxCommon to 23.2.0-rc.2 (#1727) * Update Package.resolved Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Kiryl Dzehtsiarenka <kiryl.dzehtsiarenka@mapbox.com>
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating options for an off-screen annotation with
visibilityset totrueunhides the corresponding view which may result in it being displayed on top of the map. This PR addresses this issue by preventing updated view annotation to be un-hidden during the update.With this change view annotation are only shown as a result of view annotation position update event.
Pull request checklist:
## mainheading near the top).PRs must be submitted under the terms of our Contributor License Agreement CLA.