Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles and maps built with the map factory framework should report progress #35

Closed
david-rhodes opened this issue Apr 26, 2017 · 1 comment

Comments

@david-rhodes
Copy link

As a developer, I should know when a tile is finished loading (from the web), as well as any post-processing that happens after the tile is fetched (texture generated, meshes built, etc.). This will help to create animations, avoid temporal coupling, and allow for loading screens, etc.

david-rhodes pushed a commit that referenced this issue May 25, 2017
* add state and state events to map visualizer & factories

* move progress decrement to the bottom of web callback

* add unregister to progress events on destroy
add loading panel to drive demo
change progress to protected

* fix loading panel parameters in the scene

* Roll back before 5.6 corruption.

* Fixing a bug where the flatterrainfactory would cause the entire progress reporting system to fail.
Fixed a bug where the scriptable objects could get in bad state due to incorrect progress count.
Organized code to follow guidelines.

* Making example scenes consistent and sharing the same flat terrain factory.

* Added new example showing off terrain snapping (since we removed vector data from slippy and replaced all other examples with flat terrain)
@david-rhodes
Copy link
Author

First pass progress reporting has been implemented: #89.

The AbstractMap has an initialized event, but this is used for doing conversions that require specific map attributes (reference tile and world scale, etc.). The MapVisualizer now has state changed events, as well as all the TileFactories. Use these to know when specific factories, or the entire map are done loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant