Merge latest master into dev to sync versions #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/0.11.0 to master
…-code-snippet Merge Getting Started code snippet into master
IodaMikeMapbox
approved these changes
Apr 1, 2020
chezzdev
reviewed
Apr 1, 2020
| /** | ||
| This file shows basic Vision SDK configuration steps. | ||
| */ | ||
| // This file shows basic Vision SDK configuration steps. |
There was a problem hiding this comment.
I'd leave the current formatting of example headers. Didn't notice that in PR to master.
There was a problem hiding this comment.
Formally, it was an empty doc comment which is incorrect.
I propose to merge the current PR anyway to sync the state, but we can use multiline comment
/*
This file shows basic Vision SDK configuration steps.
*/here and in the rest of places later (while we're merging examples/code snippets).
Does that make sense?
There was a problem hiding this comment.
I'm ok to merge it like this and adjust with other example PRs.
As for the comment look, we have already chosen the style for such comments (all the example files follow it), do you suggest to change it?
chezzdev
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of PR #283 a code snippet for "Getting Started guide" was introduced.
Then during merging the changes into a
masterbranch, some minor fixes were made.Now we need to sync the minor fixes from
masterbranch withdevbranch.Checks:
devbranchLinked issues:
#283
#284