Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting started code snippet to show basic configuration steps #283

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Getting started code snippet to show basic configuration steps #283

merged 3 commits into from
Mar 31, 2020

Conversation

dersim-davaod
Copy link
Contributor

Checks:

  • Update changelog
  • Rebase to dev branch
  • Assign reviewers

Linked issues: https://github.com/mapbox/ios-sdk/pull/899

@dersim-davaod dersim-davaod added iOS P0 Blocker or must-have documentation labels Mar 31, 2020
@dersim-davaod dersim-davaod self-assigned this Mar 31, 2020
chezzdev
chezzdev suggested changes Mar 31, 2020
View reviewed changes
Examples/VisionExamples.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
Docs/CHANGELOG.md Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
Examples/VisionExamples/Examples/Basics/GettingStartedViewController.swift Outdated Show resolved Hide resolved
@dersim-davaod dersim-davaod marked this pull request as ready for review March 31, 2020 10:34
@dersim-davaod dersim-davaod force-pushed the dersim-davaod-getting-started-example branch from 1146432 to 6f51596 Compare March 31, 2020 11:01
chezzdev
chezzdev approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@chezzdev chezzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dersim-davaod dersim-davaod merged commit 31cfcf1 into dev Mar 31, 2020
@dersim-davaod dersim-davaod deleted the dersim-davaod-getting-started-example branch March 31, 2020 11:42
This was referenced Mar 31, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chezzdev chezzdev chezzdev approved these changes

@IodaMikeMapbox IodaMikeMapbox IodaMikeMapbox approved these changes

Assignees

@dersim-davaod dersim-davaod

Labels
documentation iOS P0 Blocker or must-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dersim-davaod @chezzdev @IodaMikeMapbox