This repository has been archived by the owner on Apr 24, 2024. It is now read-only.
Include simplestyle.style in API #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,159 @@ | |||
| describe('L.mapbox.markerLayer', function() { | |||
There was a problem hiding this comment.
Looks like the content of this file and test/spec/marker_layer.js are swapped.
|
Looks good.
Let's add a test for this. Anything we need to consider from |
I can't think of anything, but will test polygon-popups before shipping. Fixed up the test comment, renamed, and tested the options aliasing. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jfirebaugh could you review this?
Behavior of
mapconstructor is:markerLayeris provided, it pre-emptsfeatureLayer, otherwisefeatureLayeris the default.map.markerLayerandmap.featureLayerpoint to the same thing