Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-fix: Missing layer bridges #201

Closed
samely opened this issue Jun 28, 2016 · 22 comments
Closed

To-fix: Missing layer bridges #201

samely opened this issue Jun 28, 2016 · 22 comments
Labels

Comments

@samely
Copy link

samely commented Jun 28, 2016

Objective

Add missing layer tag to bridges in major or minor highways.

Tasks

The below tasks are updating everyday from Monday to Friday with the latest errors in OpenStreetMap

To-Fix issue:

Changeset comment

Adding missing layer tag to bridges using #to-fix  https://github.com/mapbox/mapping/issues/201

Coverage

All countries in this list: https://s3.amazonaws.com/mapbox/to-fix/mbtiles.txt

Tools for edition

Instructions

  • Check satellite imagery/Mapillary to make sure a bridge is visible:
    • If a bridge is visible add layer=1 tag. For complex intersections add appropriate layer= value based on the overlap order
    • If bridge clearly does not exist and there is no crossing ways, remove the bridge tag
  • If editing in an actively mapped area, add a note instead of making a fix.
  • If satellite imagery isn't clear click on not an error of to-fix

Common issues

image

image

image
Add layer=1 tag

How are we doing the error detection?

We are using osm-qa-tiles and osmlint selfIntersectingHighways

Who will work on these tasks?

Everybody is available to work on resolving these issues. However, @mapbox/data-team (Peru office) will work on everyday.

Question

Tag @planemad or @Rub21 for questions.

cc. @mapbox/team-data

@samely samely added the task label Jun 28, 2016
@planemad
Copy link
Contributor

@samely the way might also have an incorrect bridge tag. Please check updated instructions.

@dannykath
Copy link

Missing layer bridges minor issues from 07/11/2016 - 07/14/2016
Date N° detected error Total Fixed
Monday 11th, July 93026 5220
Tuesday 12th, July 104140 5701
Total -- 10921

@dannykath
Copy link

This is the Andy's comment:

advice

@mapbox/team-data

@tankaru
Copy link

tankaru commented Jul 20, 2016

Hello Mapbox Data Team mappers,

Last week I had a discussion with one of your team members here.
https://www.openstreetmap.org/changeset/40603672

I want to ask you about your tagging standard.

When a waterway has "layer=-1" and a crossing bridge has no layer tag, do you add "layer=" to the bridge? And what about its value?
I think "layer=
" is not required in this case, because the waterway already has layer tag. Even if "layer=*" is required, its value should be "layer=0".
(Note: "layer=-1" is valid and does not mean that object is underground. See http://wiki.openstreetmap.org/wiki/Key:layer)

And I have a favor to ask. If you don't have any rational basis, please do not modify existing tags.
I think existing tag has priority.

Thanks.

@bhousel
Copy link

bhousel commented Jul 20, 2016

Waterways do not need layer tags. Bridges, tunnels, etc do not need layer tags except in cases where multiple bridges or multiple tunnels cross over one another.

I hope we are not adding unnecessary layer tags, because these tags do nothing other than suppress valid warnings and make it more difficult for downstream consumers to use OSM.

@bhousel
Copy link

bhousel commented Jul 20, 2016

Btw it is pretty clear from the Japan GSI ortho imagery layer that these features are indeed bridges and not culverts. (A culvert is a pipe/tube that the water flows through).

screenshot 2016-07-20 12 28 06

@Andygol
Copy link
Contributor

Andygol commented Jul 20, 2016

Hey @tankaru
there is quote from http://wiki.openstreetmap.org/wiki/Key:layer#Guidelines concerning waterways

Rivers and streams should not be tagged with layer -1 along long sections of their length, crossings should be tagged like other crossings with bridges, tunnels and layer. Waterways that are covered may be tagged with covered=yes and are generally rendered as if they flow underneath built features. Where a highway is at the same level as a waterway, you can add ford=*.

and http://wiki.openstreetmap.org/wiki/Key:layer#Things_to_avoid

Rivers and streams should not be tagged with layer -1 along their entire length or long sections as it makes harder to detect missing bridges for roads passing over waterways.

@bhousel

Although some map rendering and quality assurance services assume that bridges and tunnels are at layers +1 and -1 respectively, it is better to explicitly state the layer for all bridges and tunnels.

@bhousel
Copy link

bhousel commented Jul 20, 2016

@bhousel

Although some map rendering and quality assurance services assume that bridges and tunnels are at layers +1 and -1 respectively, it is better to explicitly state the layer for all bridges and tunnels.

We have never added explicit layer tags in iD.

@Andygol
Copy link
Contributor

Andygol commented Jul 20, 2016

Validator in JOSM notify about intersection of features when anyone of them missed layer=* tag

java openstreetmap editor 2016-07-20 20-36-22

@bhousel
Copy link

bhousel commented Jul 20, 2016

Validator in JOSM notify about intersection of features when anyone of them missed layer=* tag

That's so weird.. Neither Keepright nor Osmose complain as long as the bridge/tunnel tag is there.

@tankaru
Copy link

tankaru commented Jul 21, 2016

Thanks all for your comments.

Rivers and streams should not be tagged with layer -1 along their entire length or long sections

Yes. In Japan many rivers are tagged with "layer=-1" to entire way, but it's not a good manner. Layer tag should be added to limited way. I think it's not invalid but it's not good way. This is another problem.

it is pretty clear from the Japan GSI ortho imagery layer that these features are indeed bridges and not culverts

I agree. I just wanted to ask him/her why he/she tagged as culvert.

@piligab
Copy link

piligab commented Sep 5, 2016

Missing layer bridges minor Progress issues from 08/29/2016 - 08/31/2016

Date N° detected error Total Fixed
Tuesday 30th, August 92443 253
Total -- 253

@piligab
Copy link

piligab commented Sep 12, 2016

Missing layer bridges minor Progress issues from 09/05/2016 - 09/09/2016

Date N° detected error Total Fixed
Monday 05th, September 92,303 231
Tuesday 06th, September 92,078 218
Thursday 08th, September 90,797 431
Friday 09th, September 90,318 44
Total -- 924

@piligab
Copy link

piligab commented Sep 17, 2016

Missing layer bridges minor Progress issues from 09/12/2016 - 09/16/2016

Date N° detected error Total Fixed
Monday 12th, September 90,407 246
Tuesday 13th, September 90,204 335
Wednesday 14th, September 89,880 319
Thursday 15th, September 89,589 336
Friday 16th, September 89,271 358
Total -- 1,594

@1ec5
Copy link

1ec5 commented Sep 23, 2016

The JOSM warning is quite a pedantic one. As #201 (comment) points out, JOSM is the outlier here. Is there any evidence that data consumers are encountering problems caused by ways such as this bridge lacking layer tags, or is this just mapping for the validator? 😕

@piligab
Copy link

piligab commented Sep 26, 2016

Missing layer bridges minor Progress issues from 09/19/2016 - 09/23/2016

Date N° detected error Total Fixed
Monday 12th, September 88,996 346
Tuesday 13th, September 88,665 351
Wednesday 14th, September 88,365 376
Thursday 15th, September 87,952 393
Friday 16th, September 100,019 324
Total -- 1,790

@dannykath
Copy link

Missing layer bridges major Progress issues from 09/19/2016 - 09/23/2016

Date N° detected error Total Fixed
Tuesday 20th, September 65,238 89
Wednesday 21th, September 65,142 102
Thursday 22th, September 65,062 124
Friday 23th, September 81,227 80
Total -- 395

@piligab
Copy link

piligab commented Oct 29, 2016

Missing layer bridges minor Progress issues from 10/24/2016 - 10/28/2016

Date N° detected error Total Fixed
Tuesday 25th, October 98,774 331
Wednesday 26th, October 98,395 342
Thursday 27th, October 98,395 360
Friday 28th, October 97,704 240
Total -- 1,273

Missing layer bridges major Progress issues from 10/24/2016 - 10/28/2016

Date N° detected error Total Fixed
Tuesday 25th, October 81108 48
Wednesday 26th, October 81092 109
Thursday 27th, October 81092 69
Friday 28th, October 80985 110
Total -- 336

@dannykath
Copy link

Missing layer bridges major Progress issues from 10/31/2016 - 11/02/2016

Date N° detected error Total Fixed
Monday 31th, October 80923 103
Wednesday 02nd, November 80853 133
Total -- 236

@piligab
Copy link

piligab commented Nov 6, 2016

Missing layer bridges minor Progress issues from 10/31/2016 - 11/04/2016

Date N° detected error Total Fixed
Monday 31th, October -- 251
Wednesday 02nd, November 80,854 259
Thursday 03rd, November 97,259 330
Friday 04th, November 80,720 241
Total -- 1,081

@piligab
Copy link

piligab commented Nov 13, 2016

Missing layer bridges minor Progress issues from 11/07/2016 - 11/11/2016

Date N° detected error Total Fixed
Monday 07th, November 96545 304
Tuesday 08th, November 96320 318
Friday 11th, November 96047 285
Total -- 907

@piligab
Copy link

piligab commented Nov 21, 2016

Missing layer bridges minor Progress issues from 11/14/2016 - 11/18/2016

Date N° detected error Total Fixed
Monday 14th, November 95861 359
Tuesday 15th, November 95176 364
Total -- 723

@maning maning closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants