Added support for creating an mbtile file from an ArcGIS server-generated image cache #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, this adds a lot of switches in that loop. Can you try refactoring this into two loops - one for ags-style, one for not - and the actual insertion into the db as a separate method? |
|
Yep, I can do that, but for my own education, what is the objective, to made the code more readable? |
|
Yes, essentially - if there's a much-different directory structure, it makes sense to have a separate chunk of code for handling it. |
tmcw
added a commit
that referenced
this pull request
Apr 22, 2013
Added support for creating an mbtile file from an ArcGIS server-generated image cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AGS caches use a different tiling scheme, so added that as a scheme option. One directional for now, added exception handling and debug logging to go with it.