Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best practice configuration so that "npm rebuild" works? #646

Open
Apollon77 opened this issue Apr 27, 2022 · 1 comment
Open

Best practice configuration so that "npm rebuild" works? #646

Apollon77 opened this issue Apr 27, 2022 · 1 comment

Comments

@Apollon77
Copy link

Hello,

In https://github.com/mapbox/node-pre-gyp#configuring an example config is shown which is adapted by many libraries that use node-gyp. We found out that this is not really working when people use "npm rebuild" on the root dir level after an nodejs upgrade in general, because this config always state "hey I'm already build and existing" even after a node.js upgrade.

After many experiments we found out that "--update-binary" as additional parameter is a ways to achieve that "npm rebuild" also updates the binary.

While discussing this in the "canvas" library" the question arised whats the "official node-pre-gyp" statement to that topic because the example is not containign this.

It would be awesome to get some opiions and insights from you as the experts :-)

More details about the current discussion we had and especially infos and effects of the alternative options like "lets user execute npm install instead of rebuild" can be found at Automattic/node-canvas#1982

Thank you very much!

Ingo Fischer

@cclauss
Copy link
Collaborator

cclauss commented Apr 14, 2024

For support of Node.js > v17, see the workaround:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants