-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1032: add constants for file open #1078
Conversation
Looks good, thanks! |
I've added a sample test for the shared database, to test a small aspect of it. Ideally we'd have more testing of the shared database but it seems like a more niche feature. On the other hand, I haven't seen tests specifically aimed at read-only databases either. |
@gms1 could you shine some light as to why the database creation is failing in the test I added? That seems to be the default way to open databases of different modes without the URI protocol. |
@kewde
or if compiled using SQLITE_USE_URI=1, or in combination with sqlite3.SQLITE_OPEN_URI, we can also use:
quoting from https://www.sqlite.org/inmemorydb.html |
please review the added/modified tests |
hm all tests are passing during the first run at least, but only on linux, the "shared memory database" tests are failing during the second run: "SQLITE_ERROR: no such access mode: memory" running these tests on my linux box works fine:
|
The test pass for the SQLite3 package that has been bundled with the application.
The version in which it is supported is: The external library for Ubuntu 12.04.5 LTS does not support it. |
@gms1 |
@kewde |
Thank you for the contribution @gms1! |
This PR only propagates some missing constants for file open to JavaScript:
please see #1032 for a description of possible use cases
Flags For File Open Operations