-
Notifications
You must be signed in to change notification settings - Fork 15
Comparator for minor road changed #59
Comments
Let's review this compare function. It looks like it's too noisy at this point to be useful. |
Edited a path road review:This compare function was written especially for looking into Pokemon mappers who started editing new footways , pedestrians and cycleways. It looks for any of the ways being added and also modifications of this ways. The code looks like this: https://github.com/mapbox/osm-compare/blob/master/comparators/path_road_changed.js There was a lot of noise on this compare function approximately But, we have another compare functions like new footway created which is producing a good results and also less noise and also focussing on pokemon mappers mainly. So, the edited a path road compare function doesn’t make much sense to me right now but to scale down we can remove cc @geohacker @manoharuss @chtnha @batpad @amishas157 |
@krishnanammala are you suggesting that we turn this compare function off? |
@geohacker Yes , since the compare that @bkowshik built Pokemon-footway has the same theme. So we can turn this off and improve the new one in the future. |
Catch modified/additions for the following: highway=pedestrian,footway,cycleway,track,path
An inverse of the major-road-changed to monitor PokemonGo edits. Context: https://github.com/mapbox/data/issues/2328
The text was updated successfully, but these errors were encountered: