Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Comparator for minor road changed #59

Closed
maning opened this issue Dec 23, 2016 · 4 comments
Closed

Comparator for minor road changed #59

maning opened this issue Dec 23, 2016 · 4 comments
Assignees

Comments

@maning
Copy link
Contributor

maning commented Dec 23, 2016

Catch modified/additions for the following: highway=pedestrian,footway,cycleway,track,path

An inverse of the major-road-changed to monitor PokemonGo edits. Context: https://github.com/mapbox/data/issues/2328

@geohacker
Copy link
Contributor

Let's review this compare function. It looks like it's too noisy at this point to be useful.
@krishnanammala can you outline how we can tighten this please?

@krishnanammala
Copy link
Contributor

Edited a path road review:

This compare function was written especially for looking into Pokemon mappers who started editing new footways , pedestrians and cycleways. It looks for any of the ways being added and also modifications of this ways.

The code looks like this: https://github.com/mapbox/osm-compare/blob/master/comparators/path_road_changed.js

There was a lot of noise on this compare function approximately ~19000 features were flagged by OSMcha and I randomly gone through some of the features and observed mostly good edits from the experienced mappers mainly adding connections to the nearby buildings, and links between two ways etc.

But, we have another compare functions like new footway created which is producing a good results and also less noise and also focussing on pokemon mappers mainly.

So, the edited a path road compare function doesn’t make much sense to me right now but to scale down we can remove pedestrians and cycleways from this and focus on looking into footways for now which are the motto for Pokemon mappers.

cc @geohacker @manoharuss @chtnha @batpad @amishas157

@geohacker
Copy link
Contributor

@krishnanammala are you suggesting that we turn this compare function off?

@krishnanammala
Copy link
Contributor

@geohacker Yes , since the compare that @bkowshik built Pokemon-footway has the same theme. So we can turn this off and improve the new one in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants