First GID property is always null when using TMXMapReader

[csueiras]

The first gid property is always null when using the TMXMapReader, the older MapReader used to set it in the buildMap method

tileset = readTileset(xmlPath + tileSetSource);
tileset.setFirstgid(firstGid);
tileset.setSource(tileSetSource);
tilesets.set(i, tileset);

I'll create a PR to also set this property in the TMXMapReader.

[bjorn]

The first gid property is always null when using the TMXMapReader, the older MapReader used to set it in the buildMap method

Actually, TMXMapReader is the older reader, though it appears to be still used and has seen further changes after MapReader was introduced in e950500 (as part of #1637).

@mikepthomas Was the MapReader class supposed to replace TMXMapReader? Is there a reason to have both? Ideally we would only have a single reader class.

[mikepthomas]

Completely agree. MapReader was intended to replace TMXMapReader however it is using JaxB simplify the code to load the the map. JaxB was deprecated and removed in JDK 11 (However it is still available as an external dependecy) my preference would be to remove the MapReader I created and use the TMXMapReader

[bjorn]

Alright, let's remove MapReader again then. :-)

[csueiras]

Wouldn't this still be a bit of a fix since otherwise there's no way to access the firstgid property?