Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project automapping rules file is not updated until maps are reopened #3176

Closed
eishiya opened this issue Nov 12, 2021 · 1 comment
Closed
Labels
bug Broken behavior.

Comments

@eishiya
Copy link
Contributor

eishiya commented Nov 12, 2021

(Using Tiled 2021.11.12, was testing the recent changes to make automapping work with grouped layers. I don't recall whether this issue occurred in earlier versions.)

When changing the automapping rules file for the project, the new file is not used until the map or project is reopened. The previously set file will keep being used if there was one, and the default rules.txt will be used if there wasn't a project rules file set before, in which case, Tiled will show the "No rules file found at 'rules.txt'" error message if that file doesn't exist.

This means that to make sure the new rules file is used, the project should be reopened.

I suspect the issue is that AutomappingManager::refreshRulesFile() is called when the map document is updated, but not when the project settings are updated.

@bjorn bjorn added the bug Broken behavior. label Nov 16, 2021
@bjorn bjorn closed this as completed in 957ec32 Nov 16, 2021
@bjorn
Copy link
Member

bjorn commented Nov 16, 2021

I suspect the issue is that AutomappingManager::refreshRulesFile() is called when the map document is updated, but not when the project settings are updated.

That was exactly right, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants