-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groups not removed #64
Comments
Another possible fix could be to setup a locking mechanism for all file modifications in Scribe. That wuld require more work but would prevent other similar problems in the future in other areas of the code |
In this particular case cbourget's suggested solution makes more sense, as all the groups are moved and deleted all at once in the UI, so it actually makes very little sense to make several post requests. A locking mecanism might be necessary in the future, but not for this issue. If the cloud aspect of scribeui is developped more (ex. two persons collaborating on the same map at the same time) we will have to find a solution. |
Fine with me. |
I think this was fixed in the pyramid merge, it is not an issue anymore. |
When removing many groups at once, sometimes, some of them are not removed. This is because a POST request is made for each group to be deleted and each of those request open and edit the file where groups are stored. If this file is still open from a preceding request, then the modifications are overwritten by that last request and some groups are not removed.
Making a single POST request with all the groups to be removed would fix that bug.
The text was updated successfully, but these errors were encountered: