Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Requirements] 8. Get All Map Features In A BBox #19

Closed
Rubix982 opened this issue Jun 24, 2021 · 4 comments · Fixed by #68
Closed

[Requirements] 8. Get All Map Features In A BBox #19

Rubix982 opened this issue Jun 24, 2021 · 4 comments · Fixed by #68
Assignees
Labels
feature A feature request for the SDK requirements A requirement from the PRD

Comments

@Rubix982
Copy link
Contributor

Is your feature request related to a problem? Please describe.
This issue deals with the 8th requirement from the PRD extracting all map features within a BBox

Describe the solution you'd like
The base requirements are,

  1. Bbox coordinates as an argument
  2. Layer as argument (points or traffic signs)
  3. Filter argument 1: Value list as argument (only one value or multiple values or “all”)
  4. Filter argument 2: other -- date first seen, last seen, more?

Describe alternatives you've considered
NA

Additional context
Maybe split this into 2 functions, one for traffic signs and one for points

Output is a GeoJSON object

@Rubix982 Rubix982 added feature A feature request for the SDK requirements A requirement from the PRD labels Jun 24, 2021
@OmarMuhammedAli OmarMuhammedAli self-assigned this Jul 4, 2021
@cbeddow cbeddow added this to To do in MLH Fellowship Jul 6, 2021
@Rubix982
Copy link
Contributor Author

@OmarMuhammedAli aren't first_seen and last_seen properties instead of fields?

@OmarMuhammedAli
Copy link
Contributor

@Rubix982 Yes, they're properties. We generally have no fields associated with requests for tiles endpoints in general I think.

@Rubix982
Copy link
Contributor Author

So the filtering will be done after the data has been retrieved as a GeoJSON.

What,

  • kind of filtering are you thinking of performing with the properties?
  • What kind of inputs do you imagine being sent by the users
  • What functions do you need for that?

Maybe I can create issue(s) for these and work on that.

@OmarMuhammedAli
Copy link
Contributor

OmarMuhammedAli commented Jul 11, 2021

  • User inputs should be:

    1. layer: either map feature point or traffic sign
    2. bbox: a list of the bounding box coords
    3. filters: a list of filter values supported by the API to be applied on the returned tiles
  • I can think of filtering as 2 separate processes for now:

    1. filtering related to the filter values dictated by the user
    2. Checking if the returned map features actually lie within the box (There're 2 utility issues created for that: [Utility] Check if given features exist within the bounding box #27 and [Utility] Check bounding box validity #40
  • I need to give that more thought, the same goes for the previous points.

I will keep replying to this comment If I think of anything else

@OmarMuhammedAli OmarMuhammedAli linked a pull request Jul 16, 2021 that will close this issue
@OmarMuhammedAli OmarMuhammedAli moved this from To do to Issues - In progress in MLH Fellowship Jul 19, 2021
@OmarMuhammedAli OmarMuhammedAli moved this from Issues - In progress to Done in MLH Fellowship Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature request for the SDK requirements A requirement from the PRD
Projects
Development

Successfully merging a pull request may close this issue.

2 participants