[Requirement] Get features within a bounding box

[OmarMuhammedAli]

Req no.8 Implementation: Get filtered features within a bbox

Purpose and Proposed Changes:

• Implement 2 driver functions to retrieve filtered points and traffic signs within an input bounding box
• Implement a single controller to hold the business logic and to handle both driver functions
• Implementation and modification of multiple filtering and formatting functions to serve the same purpose of the PR

Feedback required over

What kind of feedback do you require from this PR, if any? For example,

• A quick pair of 👀 on the code
• Discussion on the technical approach
• Critique on design
• Confirmation of the validity of used logic.

Feedback required when

Whenever possible 😄

Mentions

@Rubix982, @gmelodie , and @cbeddow. Would love to discuss your thoughts and feedback!

References (OPTIONAL)

Mapillary API V4

[Rubix982]

For the files,

• mapillary.py on spot
• verify.py makes sense for the formatting. I realized we do not have DocStrings over there. Created an issue for this, [Documentation] mapillary/controller/rules/verify.py does not have DocStrings #69
• format.py I like the examples, good job!
• feature.py everything makes sense and is easy to read. Nice!
• filter.py most pep8 styling issues, but the code looks better. Thank you!

I believe this is good to be merged.

[cbeddow]

existed_at is a good idea, I did not think of it, but I like this. If we want data that is newer than the last check we did, let us say on June 15th, then we find data where existed_at(June 15th) is false, and it will return all data from June16 or after. This is useful. Essentially the user is looking for first_seen_at > June 15th, result being new data since that time.

[OmarMuhammedAli]

Should I rename this to be existed_after instead?

[cbeddow]

No this is great

[OmarMuhammedAli]

Applied suggestions and fixed a bug with date_to_unix_timestamp

@cbeddow and @Rubix982, let me know if there are any further modifications you'd like to be applied, and if this is okay to be merged!

[Rubix982]

Approval from my side. 👍

[OmarMuhammedAli]

Merging to use utils on my current PR