Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Tests: iOS failure of map-mode/tile-avoid-edges #1545

Closed
stefankarschti opened this issue Aug 18, 2023 · 5 comments
Closed

Render Tests: iOS failure of map-mode/tile-avoid-edges #1545

stefankarschti opened this issue Aug 18, 2023 · 5 comments

Comments

@stefankarschti
Copy link
Collaborator

stefankarschti commented Aug 18, 2023

Image

Expected:

Image

@stefankarschti stefankarschti self-assigned this Aug 18, 2023
@acalcutt
Copy link
Collaborator

acalcutt commented Aug 18, 2023

for extra context, tile-avoid-edges and I have a history. haha
#479
#492

From what I've gathered, the first image is what it should look like now since 9ceb619 , though I have never agreed with that...it should look more like the expected in my opinion. not sure is iOS had the same issue

I'm not sure it relates to this issue, but it has been problematic in the past for me for sure.

@stefankarschti
Copy link
Collaborator Author

This is very good to know! Thank you!

@stefankarschti
Copy link
Collaborator Author

stefankarschti commented Aug 21, 2023

Actually the problem on my iOS device is that the red tile border is missing completely on the topic/drawable-fixes branch, part of the Renderer modularization implementation.

@stefankarschti stefankarschti removed their assignment Aug 25, 2023
@sjg-wdw
Copy link
Collaborator

sjg-wdw commented Jan 6, 2024

Have we fixed this one?

@stefankarschti
Copy link
Collaborator Author

stefankarschti commented Jan 8, 2024

Yes, the render test passes with this expected image:
image

commit hash

@louwers louwers closed this as completed Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants