-
Notifications
You must be signed in to change notification settings - Fork 827
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Fixed a typo in agg_rounded_rect.cpp
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you know this was a typo? Not saying it is not, just that it would be good to document.
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason i was looking for a rounded rect implementation in agg 2.5, and noticed there was a fixed bit we had not included:
http://vector-agg.cvs.sourceforge.net/viewvc/vector-agg/agg-2.5/src/agg_rounded_rect.cpp?r1=1.1&r2=1.2&
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kunitoki - since agg is basically abandoned upstream, I think we need to be quite careful about including fixes.
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. But i read "Because the primary developer of AGG has moved on to other endeavors, we happily maintain our own version of AGG with bugfixes." in the mapnik trac...
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, exactly :) So bugfixes are awesome, just need to make sure (via tests/review) that they actually fix a bug. Big apologies if you did this, just came across as a blindly-copied-swap.
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice find @kunitoki - that fix is from mcseem I see (lead author of agg) so we definitely want it without question. thanks!
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agg-2.5 is GPL, so we can't backport changes! But this particular issue looks like a typo, so lets test.
180f254
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's clearly a typo. anyway there are only 3 differences between agg 2.4 and 2.5, and they all seems typos. Btw, we already have 1 backport fix in our agg tree before this one, so...