Skip to content

Commit

Permalink
- Fixed a typo in agg_rounded_rect.cpp
Browse files Browse the repository at this point in the history
  • Loading branch information
kunitoki committed Oct 26, 2011
1 parent e837b46 commit 180f254
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deps/agg/src/agg_rounded_rect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ namespace agg
//--------------------------------------------------------------------
void rounded_rect::normalize_radius()
{
double dx = fabs(m_y2 - m_y1);
double dy = fabs(m_x2 - m_x1);
double dx = fabs(m_x2 - m_x1);
double dy = fabs(m_y2 - m_y1);

double k = 1.0;
double t;
Expand Down

8 comments on commit 180f254

@springmeyer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you know this was a typo? Not saying it is not, just that it would be good to document.

@kunitoki
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason i was looking for a rounded rect implementation in agg 2.5, and noticed there was a fixed bit we had not included:

http://vector-agg.cvs.sourceforge.net/viewvc/vector-agg/agg-2.5/src/agg_rounded_rect.cpp?r1=1.1&r2=1.2&

@rcoup
Copy link
Contributor

@rcoup rcoup commented on 180f254 Oct 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kunitoki - since agg is basically abandoned upstream, I think we need to be quite careful about including fixes.

@kunitoki
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But i read "Because the primary developer of AGG has moved on to other endeavors, we happily maintain our own version of AGG with bugfixes." in the mapnik trac...

@rcoup
Copy link
Contributor

@rcoup rcoup commented on 180f254 Oct 26, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, exactly :) So bugfixes are awesome, just need to make sure (via tests/review) that they actually fix a bug. Big apologies if you did this, just came across as a blindly-copied-swap.

@springmeyer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find @kunitoki - that fix is from mcseem I see (lead author of agg) so we definitely want it without question. thanks!

@artemp
Copy link
Member

@artemp artemp commented on 180f254 Oct 27, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agg-2.5 is GPL, so we can't backport changes! But this particular issue looks like a typo, so lets test.

@kunitoki
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's clearly a typo. anyway there are only 3 differences between agg 2.4 and 2.5, and they all seems typos. Btw, we already have 1 backport fix in our agg tree before this one, so...

Please sign in to comment.