Permalink
Browse files

- Fixed a typo in agg_rounded_rect.cpp

  • Loading branch information...
1 parent e837b46 commit 180f2543b20aa4aae27ac4b919133c601376e76b @kunitoki kunitoki committed Oct 26, 2011
Showing with 2 additions and 2 deletions.
  1. +2 −2 deps/agg/src/agg_rounded_rect.cpp
@@ -78,8 +78,8 @@ namespace agg
//--------------------------------------------------------------------
void rounded_rect::normalize_radius()
{
- double dx = fabs(m_y2 - m_y1);
- double dy = fabs(m_x2 - m_x1);
+ double dx = fabs(m_x2 - m_x1);
+ double dy = fabs(m_y2 - m_y1);
double k = 1.0;
double t;

8 comments on commit 180f254

Owner

springmeyer replied Oct 26, 2011

how do you know this was a typo? Not saying it is not, just that it would be good to document.

Member

kunitoki replied Oct 26, 2011

for some reason i was looking for a rounded rect implementation in agg 2.5, and noticed there was a fixed bit we had not included:

http://vector-agg.cvs.sourceforge.net/viewvc/vector-agg/agg-2.5/src/agg_rounded_rect.cpp?r1=1.1&r2=1.2&

Member

rcoup replied Oct 26, 2011

@kunitoki - since agg is basically abandoned upstream, I think we need to be quite careful about including fixes.

Member

kunitoki replied Oct 26, 2011

Ok. But i read "Because the primary developer of AGG has moved on to other endeavors, we happily maintain our own version of AGG with bugfixes." in the mapnik trac...

Member

rcoup replied Oct 26, 2011

yep, exactly :) So bugfixes are awesome, just need to make sure (via tests/review) that they actually fix a bug. Big apologies if you did this, just came across as a blindly-copied-swap.

Owner

springmeyer replied Oct 26, 2011

nice find @kunitoki - that fix is from mcseem I see (lead author of agg) so we definitely want it without question. thanks!

Owner

artemp replied Oct 27, 2011

agg-2.5 is GPL, so we can't backport changes! But this particular issue looks like a typo, so lets test.

Member

kunitoki replied Oct 27, 2011

it's clearly a typo. anyway there are only 3 differences between agg 2.4 and 2.5, and they all seems typos. Btw, we already have 1 backport fix in our agg tree before this one, so...

Please sign in to comment.