Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish features_at_point tolerance support #1640

Closed
springmeyer opened this issue Dec 11, 2012 · 3 comments
Closed

finish features_at_point tolerance support #1640

springmeyer opened this issue Dec 11, 2012 · 3 comments
Assignees
@artemp
Labels
mustfix
Milestone
Mapnik 2.2

Comments

@springmeyer
Copy link
Member

#1499 added very initial support for passing a tolerance to datasource features_at_point. However, it was only implemented for postgis, and needs to be done for all other datasources, along with tests. A test was added for the shape.input, but only passed because the shape.input had a bug whereby points were not actually filtered by bbox (until 02bb955 /#1630).
springmeyer pushed a commit that referenced this issue Dec 11, 2012
properly support tolerance in shape filter_at_point - refs #1640
e928c48
@springmeyer
Copy link
Member Author

/cc @manelclos

@ghost ghost assigned artemp May 9, 2013
@springmeyer
Copy link
Member Author

finished up in a3eaebd and 653e9e7. followup at #1861

@manelclos
Copy link
Member

Nice! :)

PetrDlouhy pushed a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013
@PetrDlouhy
properly support tolerance in shape filter_at_point - refs mapnik#1640
612c1c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemp artemp

Labels
mustfix
Projects
None yet
Milestone
Mapnik 2.2
Development

No branches or pull requests
3 participants
@springmeyer @artemp @manelclos