Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy constructor review #2081

Closed
1 of 4 tasks
springmeyer opened this issue Nov 14, 2013 · 2 comments
Closed
1 of 4 tasks

Copy constructor review #2081

springmeyer opened this issue Nov 14, 2013 · 2 comments
Assignees
@artemp
Milestone
Mapnik 3.0.0

Comments

@springmeyer
Copy link
Member

Copy constructors need to be reviewed, especially objects with shared_ptr members that can be part of a map. Once done this will enable proper (deep)copying of maps.

Tasks:

  • - fix all ctors
  • - test cloning maps from python, add tests to ensure they are copied correctly
  • - vet datasources for ability to be shared
  • - consider revisiting/fixing the carto-parser
@ghost ghost assigned artemp Nov 14, 2013
This was referenced Nov 14, 2013
Closed
Closed
springmeyer pushed a commit that referenced this issue Nov 14, 2013
remove unused and broken deepcopy support to be replaced in #2081 - r…
5de5ffb 
…efs #1390 and #946
@springmeyer springmeyer mentioned this issue Nov 22, 2013
Closed
@springmeyer
Copy link
Member Author

also #2252 /cc @artemp

@springmeyer
Copy link
Member Author

now testing in https://github.com/mapnik/mapnik/blob/master/tests/cpp_tests/copy_move_test.cpp, will open new issues as they arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemp artemp

Labels
None yet
Projects
None yet
Milestone
Mapnik 3.0.0
Development

No branches or pull requests
2 participants
@springmeyer @artemp