remove ltdl #1804
Merged
remove ltdl #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @artemp please merge if this looks good to you. |
|
thanks! |
springmeyer
pushed a commit
that referenced
this pull request
Sep 2, 2013
herm
added a commit
that referenced
this pull request
Oct 13, 2013
* commit 'b6040ac324814c5122d88a2b10cf9a569944f3f4': (13 commits) correct return type from std::string::substr add mention of background-image-opacity and background-image-comp-op to changelog - refs #1966 more 2.3.x changelog updates more changelog additions further develop 2.3.0 changelog always link libdl on linux - needed on some systems after #1804 - closes #1998 Additional optional dependency on librasterlite tests: fix png and web encoding tests to run only if support is available python: fix reporting of tiff and webp image support cpp tests: fix test to respect DEFINES ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ltdl is used for dynamic loading of datasource plugins in Mapnik. But it can be hard to compile on windows and is unneeded on all other platforms. On Windows we can avoid it by calling Windows api's and on On OS X 10.8 apple stopped providing ltdl but dlopen/dlfcn.h is available and the recommended way: https://developer.apple.com/library/mac/#documentation/developertools/Reference/MachOReference/Reference/reference.html
I have also researched other toolkits and how they support dynamic loading in a cross platform way and tools like gdb, llvm, and node.js/libuv also take this approach of using windows apis directly and otherwise just dlopen.
One thing this patch does not do is leverage/report any errors from
dlopen. Honestly I don't think this is critical. Ltdl provided an api to get errors but it was so buggy I ultimately disabled it. So, not accessing errors from dlopen/LoadLibrary does not regress any functionality at all. In the future we could consider adding this if it seems needed, but I think we should not mess with custom errors for now.