Feature/premultiply demultiply move #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he code. The image_data object is now responsible for keeping track of its own premultiplied_alpha status. Created a new utility method in image_util to preform premultiplication. Added visitor pattern to several different methods as well to prepare for image_data_any including compositing. Ref #2633
… out linking errors with vis to hidden.
…premultiplication of data prior to compositing. There still seem to be some errors in the resulting images, but I am not quite sure what they are yet.
|
I pushed a few more updates to this, however, still have some failing tests. I have left in some debug code in image_compositing.cpp that throws exceptions if the src or dst variables are not premultiplied, but as per @springmeyer 's request, I will have them removed prior to finishing this pull request. |
|
This is excellent work. Nice choice on throwing in the composite function for now. I actually even put in an abort to make it easy to get a backtrace of where non-premultiplied pixels were comping from. Will push a few fixes in a moment. All tests are passing for me now after 364fb49. |
springmeyer
pushed a commit
that referenced
this pull request
Jan 15, 2015
Feature/premultiply demultiply move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing currently for this, but wanted to go ahead and create the pull request so that @artemp and @springmeyer could start to review as there are a lot of changes.
Ref #2633