Fix situation where offset_converter might start off with an SEG_END … #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from the vertex, therefore starting invalid processing. Tests added to confirm fix. Ref #2937
|
I'm getting a rendering bug with this. This is without text-spacing or similar, so it is rendering.
Currently tracking down if it's in this PR, or also present in master |
|
Bug is not caused by this PR |
|
@flippmoke - my understanding is that this pull was created as a guess of what the problem was in #2937. Now that you've fixed the real issue behind #2937 should this be discarded or still has value in being applied? |
|
per chat @flippmoke says still worthy to apply. |
springmeyer
pushed a commit
that referenced
this pull request
Jul 7, 2015
Fix situation where offset_converter might start off with an SEG_END …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…from the vertex, therefore starting invalid processing. Tests added to confirm fix. Ref #2937