Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub C++ version of pgraster test #3358

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

strk
Copy link
Contributor

@strk strk commented Mar 11, 2016

NOTE: this is a much less interesting than the python test

This is a spin-off of #3348, only including the testcase stub.

NOTE: this is a much less interesting than the python test
@strk
Copy link
Contributor Author

strk commented Mar 23, 2016

BTW, https://github.com/mapnik/python-mapnik/blob/master/test/python_tests/pgraster_test.py should really be ported to C++ for it to be a good test.

@lightmare
Copy link
Contributor

I think the run function should be local, too. Unit tests are linked into a single executable. Either make it static, or move to unnamed namespace like you did dbname.

@strk
Copy link
Contributor Author

strk commented Apr 2, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants