Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile better entrypoint #938

Merged
merged 11 commits into from
Jul 4, 2024

Conversation

simonseyock
Copy link
Contributor

This is a draft for solving #937

It is not fully tested.

@simonseyock
Copy link
Contributor Author

This is now fully tested. The CI process is not yet adapted.

@simonseyock simonseyock marked this pull request as ready for review July 2, 2024 07:01
@simonseyock simonseyock force-pushed the dockerfile-better-entrypoint branch 2 times, most recently from 04e31f1 to 0735445 Compare July 3, 2024 07:34
@simonseyock simonseyock force-pushed the dockerfile-better-entrypoint branch 11 times, most recently from 9b7b153 to c4a25dd Compare July 3, 2024 09:03
@simonseyock
Copy link
Contributor Author

simonseyock commented Jul 3, 2024

I updated the dockerbuild github action. I removed the workflow_dispatch trigger because:
a) it made the action way more complicated (double build definitions for every flavor)
b) a dockerfile should always correspond to a git tag imho. so if a tag should be republished it needs to be deleted and recreated

Here is an example workflow run without pushing the images: https://github.com/simonseyock/mapproxy/actions/runs/9774970243/job/26984393702

@simonseyock simonseyock force-pushed the dockerfile-better-entrypoint branch from c4a25dd to 2de4282 Compare July 3, 2024 09:08
Dockerfile Outdated Show resolved Hide resolved
@weskamm
Copy link
Member

weskamm commented Jul 4, 2024

I updated the dockerbuild github action. I removed the workflow_dispatch trigger because: ...

As long as we dont need to publish older images again (which i currently see no reason for), this should be fine

Copy link
Member

@weskamm weskamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Lets see if tests from Hannes succeed before merging, but you get my thumbs up!

@hblitza
Copy link
Contributor

hblitza commented Jul 4, 2024

Thanks @simonseyock. I tested it locally - successfully for dev,plain,nginx both alpine and debian.

@simonseyock simonseyock merged commit df898e9 into mapproxy:master Jul 4, 2024
6 checks passed
@simonseyock simonseyock deleted the dockerfile-better-entrypoint branch July 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants