-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor edits to README.md #44
Conversation
"Rusts" --> "Rust's" (in the "Programming Model" section) Edited the first paragraph for more clarity. I think you were saying that Azul supports development of desktop apps that were written in Rust AND were supported by the Mozilla WebRender rendering engine, but the original sentence was unclear about that. I rewrote that part and then wrote about Azul using a CSS/DOM model in a separate sentence. It's to be clear that Azul uses the model, not the desktop apps (if that was what you meant).
Pull Request Test Coverage Report for Build 573
💛 - Coveralls |
Yeah but the applications do use CSS and a DOM model... I mean just look at the examples, they all use a DOM and a CSS stylesheet.
In my sentence the "supported by the Mozilla WebRender rendering engine" clearly refers to the framework, but your sentence sounds like you have to already have to have an existing application using WebRender or directly use WebRender in your application, which is not the case. Azul uses WebRender, yeah, therefore all applications using Azul also use WebRender. But that is implied by saying that the framework uses WebRender - so if you use the framework, then you use WebRender, obviously. And if you want to change it to two sentences, you might as well remove that sentence, since it's more or less the "tagline" of Azul, which is usually the project summed up in one sentence. So overall I think the sentence is correct and you just misunderstood the architecture of the framework - applications that use Azul use a CSS and DOM model, because that's the API exposed by the framework. Your application doesn't use WebRender directly, Azul uses WebRender. And yes, applications do use a DOM and CSS model to do layout and styling. Maybe "built on top of" instead of "supported by" is more clear, since "supported" can mean many things - Azul is built on top of WebRender. |
Rewrote the first sentence to make it one sentence again and to make it more accurate.
I took your feedback and rewrote it again. I hope it helps. |
Well now it's just the original sentence again but without commas forming a bandworm sentence. "Utilizing the Mozilla WebRender rendering engine for rapid development" sounds like the rapid development is due to WebRender, not due to Azul. My suggestion would be to leave the original sentence alone and just change "supported by the Mozilla WebRender rendering engine" to "built on top of the Mozilla WebRender rendering engine". |
Change "utilizing" to "built on."
I made it more clear that Azul is built on WebRender. |
Yeah, maybe in the future I should leave out mentioning WebRender entirely. But thanks for looking over it, I think it's fine for now. |
Typo corrections & slight rewording in README.md
"Rusts" --> "Rust's" (in the "Programming Model" section)
Edited the first paragraph for more clarity. I think you were saying that Azul supports development of desktop apps that were written in Rust AND were supported by the Mozilla WebRender rendering engine, but the original sentence was unclear about that. I rewrote that part and then wrote about Azul using a CSS/DOM model in a separate sentence. It's to be clear that Azul uses the model, not the desktop apps (if that was what you meant).
Fixes #43