Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameBufferHA3: Improved version of FrameBufferHA2 #1178

Closed
wants to merge 8 commits into from
Closed

FrameBufferHA3: Improved version of FrameBufferHA2 #1178

wants to merge 8 commits into from

Conversation

bailuk
Copy link
Contributor

@bailuk bailuk commented Oct 24, 2020

Add FrameBufferHA3 and make it default:
HA3 fixes an issue of HA2: FrameBufferHA2 sometimes prevents the LayerManager thread from terminating and then does not free its resources.

Changes:

  • Reorganize class hierarchy of FrameBuffer classes.
  • All FrameBuffer classes are now a subclass of abstract FrameBuffer
  • Remove obsolete FrameBufferHA
  • FrameBufferOld (original MapsForge FrameBuffer) and FrameBufferH2 are unchanged and can still be used as a fallback
  • Add improved FrameBufferHA3 and make it default. Can be configured by changing FrameBufferController.FRAME_BUFFER_HA3

@devemux86
Copy link
Collaborator

Thanks for the clean work and the separate commits.
(makes easier the review)

Merged via 2679747 (with the option in Parameters class).

@devemux86 devemux86 closed this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants