Fix: specification: tag IDs first, then variable values second #1374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I've been writing my own parser for Mapsforge map files and I think the current wording around variable tag values is a little confusing.
The specification
docs/Specification-Binary-Map-File.md
makes it sound like tag IDs and their variable values are interleaved. For example something liketag_id_1, variable_value_1, tag_id_2, variable_value_2
.In reality, it seems like files are written with all the tag IDs first, then all the tag values second, like
tag_id_1, tag_id_2, variable_value_1, variable_value_2
. See here for the implementation inmapsforge-map-reader
.I'm not entirely sure about how I've changed the wording, but I think it helps clear it up.
Thanks for working on this great project!