Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: specification: tag IDs first, then variable values second #1374

Merged
merged 1 commit into from Dec 8, 2022
Merged

Fix: specification: tag IDs first, then variable values second #1374

merged 1 commit into from Dec 8, 2022

Conversation

GeorgeHoneywood
Copy link
Contributor

Hey! I've been writing my own parser for Mapsforge map files and I think the current wording around variable tag values is a little confusing.

The specification docs/Specification-Binary-Map-File.md makes it sound like tag IDs and their variable values are interleaved. For example something like tag_id_1, variable_value_1, tag_id_2, variable_value_2.

for each tag of the POI:

    tag id as VBE-U INT
    variable values as different data types, whose content can be evaluated from tag's wildcard

In reality, it seems like files are written with all the tag IDs first, then all the tag values second, like tag_id_1, tag_id_2, variable_value_1, variable_value_2. See here for the implementation in mapsforge-map-reader.

I'm not entirely sure about how I've changed the wording, but I think it helps clear it up.

Thanks for working on this great project!

The specification currently makes it sound like tag IDs and their variable values are interleaved. For example something like `tag_id_1, variable_value_1, tag_id_2, variable_value_2`.

In actuality, files are written with all the tag IDs first, then the tag values, like `tag_id_1, tag_id_2, variable_value_1, variable_value_2`.
@devemux86 devemux86 added this to the 0.19.0 milestone Dec 8, 2022
@devemux86 devemux86 merged commit 63df515 into mapsforge:master Dec 8, 2022
@devemux86
Copy link
Collaborator

Thanks!

@GeorgeHoneywood GeorgeHoneywood deleted the patch-1 branch December 8, 2022 19:10
@devemux86 devemux86 changed the title fix: specification: tag IDs first, then variable values second Fix: specification: tag IDs first, then variable values second Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants