Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qt] fix warning #10641

Merged
merged 1 commit into from
Apr 5, 2019
Merged

[qt] fix warning #10641

merged 1 commit into from
Apr 5, 2019

Conversation

gmoryes
Copy link
Contributor

@gmoryes gmoryes commented Apr 4, 2019 •
edited
Loading

image

bykoianko
bykoianko approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@bykoianko bykoianko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Но странный метод... Я бы передавал просто по ссылке и модифицировал параметр.

@bykoianko bykoianko merged commit ce8b256 into mapsme:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bykoianko bykoianko bykoianko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmoryes @bykoianko