Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have equivalents to Eclipse error markers #18

Open
gunnarmorling opened this issue Nov 5, 2017 · 3 comments
Open

Have equivalents to Eclipse error markers #18

gunnarmorling opened this issue Nov 5, 2017 · 3 comments

Comments

@gunnarmorling
Copy link
Member

It'd be great to see warnings/errors similar to the way it's done in Eclipse, i.e. with warning/error markers right on the mapper interface and its annotations, e.g. if a mapping method fails to map some target attributes or if a source() property is misspelled.

@mkrumpholz
Copy link

Yeah, this should be implemented to see the errors earlier. Now the error is visible at compile time. This is OK but it could be visible earlier, just do the same checks and add an error highlighter. IDEA runs the implemented checks in the background. :)

@filiphr
Copy link
Member

filiphr commented Jul 4, 2020

@mkrumpholz we do have some checks and inspections.

What Gunnar was referring to (I think) is to get the warnings / errors from the compiler and not reimplement the same logic as we have in the Mapstruct code generator. I don't know much about the Eclipse plugin, but from what I've seen the Eclipse plugin uses the compiler output to show the error markers.

Do you have some ideas for how to achieve this @mkrumpholz?

@mkrumpholz
Copy link

IntelliJ parses the code and builds the internal tree (PSI). I think you know that when you're on plugin development. The checks are part of that process and i would expect that you could have a bit more generic code as a module to use it in the code generator as well as in the code analysis in the IDEA plugin. And i think @gunnarmorling is talking about the error highlighting in IDEA that is not asking the java compiler for the errors but using its own checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants