Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Missing dependency for leyndo #356

Closed
mvglasow opened this issue Nov 27, 2014 · 6 comments · Fixed by #364
Closed

Missing dependency for leyndo #356

mvglasow opened this issue Nov 27, 2014 · 6 comments · Fixed by #364
Assignees

Comments

@mvglasow
Copy link

Just trying to build Mapzen Open, but there seems to be a missing dependency.
git clone git@github.com:mapzen/leyndo.git
(in open/scripts/dependency/install-leyndo.sh)
fails with error "repository not found".

@ecgreb
Copy link
Contributor

ecgreb commented Nov 28, 2014

Yikes! Sorry about that. We added leyndo from a private repo to securely inject OSM credentials into production builds. We need to make this dependency optional for debug builds. Thanks for the heads up.

In the meantime here is a workaround you can use to build and run the app:

  1. Delete scripts/dependencies/install-leyndo.sh
  2. Remove all 3 leyndo dependencies from pom.xml
  3. Delete SimpleCrypt.java and SimpleCryptTest.java
  4. Delete SimpleCrypt provider methods in AppModule and TestAppModule
  5. Remove all usages of SimpleCrypt in MapzenApplication
  6. Modify LoginActivity#doLogin() to simply call startBaseActivity()

Now when you click the login button it should bypass OSM login and take you right into the app.

@ecgreb ecgreb self-assigned this Nov 28, 2014
@mvglasow
Copy link
Author

Thanks, now at least installing dependencies works and I can start the build process. However, there are some tests that fail because of this (LoginActivity, DataUploadService). I'm trying to remove them one by one and will see if I get a successful build then.

@mvglasow
Copy link
Author

I removed the tests but then checkstyle complained about 22 missing imports, so I just skipped the whole thing with mvn clean install -DskipTests -Dcheckstyle.skip=true. That and the subsequent mvn android:deploy android:run installed the app on my device.

However, when I launch it, I get the splash screen and then nothing else happens. The four dots at the bottom suggest that I should be able to swipe through four screens, but nothing happens when I attempt to swipe. Something seems stuck here...

I've pushed my changes to https://github.com/mvglasow/open. The first commit has the changes you mentioned, the second one is my adaptation of the tests.

@ecgreb
Copy link
Contributor

ecgreb commented Dec 19, 2014

Try swiping the text on the splash screen (not the logo)

@mvglasow
Copy link
Author

That did the trick, thanks! A hint on the screen would have helped, though...

@ecgreb
Copy link
Contributor

ecgreb commented Dec 19, 2014

I agree. We are working on some improvements to the login flow.
Let us know if any other issues or questions come up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants