You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
POP has three different ways it applies a scale factor to ecosys forcing data read from a file, depending on how the field_source argument to forcing_fields_add():
For shr_stream, we pass a unit_conv_factor argument
For POP monthly calendar, the scale factor is pulled out of the forcing_calendar_name argument (forcing_calendar_name%input%scale_factor)
For file_time_invariant, the scale factor must be applied separate from the file read (in forcing_init_post_processing)
For the time invariant files, we should definitely use the unit_conv_factor argument and apply the scale factor when reading the data. Note that this may not be bit-for-bit because currently the subsurface sediment flux is summed prior to applying the scale factor => this will change the order of operations.
For the POP monthly calendar files, there seem to be two options:
Pass unit_conv_factor=file_details%input%scale_factor in the forcing_fields_add() calls
Add a comment in the forcing_fields_metadata_type definition that unit_conv_factor is not used for monthly calendar files
This is not a high priority and should wait until after @klindsay28 has merged some of his science changes back to the marbl_dev branch of POP
The text was updated successfully, but these errors were encountered:
POP has three different ways it applies a scale factor to ecosys forcing data read from a file, depending on how the
field_source
argument toforcing_fields_add()
:shr_stream
, we pass aunit_conv_factor
argumentPOP monthly calendar
, the scale factor is pulled out of theforcing_calendar_name
argument (forcing_calendar_name%input%scale_factor
)file_time_invariant
, the scale factor must be applied separate from the file read (inforcing_init_post_processing
)For the time invariant files, we should definitely use the
unit_conv_factor
argument and apply the scale factor when reading the data. Note that this may not be bit-for-bit because currently the subsurface sediment flux is summed prior to applying the scale factor => this will change the order of operations.For the POP monthly calendar files, there seem to be two options:
unit_conv_factor=file_details%input%scale_factor
in theforcing_fields_add()
callsforcing_fields_metadata_type
definition that unit_conv_factor is not used for monthly calendar filesThis is not a high priority and should wait until after @klindsay28 has merged some of his science changes back to the
marbl_dev
branch of POPThe text was updated successfully, but these errors were encountered: