Skip to content

Commit

Permalink
ENH: Port fish scripts to bash; remove Electron
Browse files Browse the repository at this point in the history
SHEESH why did I write these in fish in the first place.
The bash script porting closes #149!

I ended up removing the very basic in-progress electron/ version,
because it added *a lot* of complexity to the minification process
-- and I'm not confident that it's actually useful to keep around,
until we go ahead with #5 and make it actually harness the node.js
library. If/when I get around to doing that, I think it'll require
the sort of changes that go beyond a few "sed" commands.

Also, I updated the copyright years in the minified attributions
(#150) -- need to actually change these throughout. Also I guess
we should include 2016 in this range? TBH I don't think we'd have
a problem with just "2016--".
  • Loading branch information
fedarko committed Sep 6, 2019
1 parent 2691741 commit b160f16
Show file tree
Hide file tree
Showing 16 changed files with 63 additions and 1,419 deletions.
5 changes: 2 additions & 3 deletions commit.fish → commit.sh
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
#! /usr/bin/fish
#! /usr/bin/env bash
# Assumes the CWD is the root of the MetagenomeScope/ repository.
./minify_files.fish
bash minify_files.fish
git add viewer/js/xdot2cy.min.js
git add viewer/css/viewer_style.min.css
git add viewer/index.min.html
git add electron/index.min.html
git commit
6 changes: 0 additions & 6 deletions electron/README.md

This file was deleted.

Binary file removed electron/bubble.png
Binary file not shown.
Binary file removed electron/bubble_fancy.png
Binary file not shown.
21 changes: 0 additions & 21 deletions electron/index.min.html

This file was deleted.

33 changes: 0 additions & 33 deletions electron/main.js

This file was deleted.

Loading

0 comments on commit b160f16

Please sign in to comment.