Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for evaluation of Arithmetic/LogicalExpr #6

Closed
pjattke opened this issue Apr 28, 2020 · 1 comment
Closed

Add tests for evaluation of Arithmetic/LogicalExpr #6

pjattke opened this issue Apr 28, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@pjattke
Copy link
Contributor

pjattke commented Apr 28, 2020

There are only very few tests for the evaluation logic of arithmetic expressions (ArithmeticExpr) and logical expressions (LogicalExpr). Even though exhaustive testing may not be required, it still would make sense to have at least a few tests for each operator involving different combinations of operand types.

See the tests for the OperatorExpr (OperatorExprTest.cpp) for an example of how this could be done and documented.
@pjattke pjattke added the enhancement New feature or request label Apr 28, 2020
@AlexanderViand
Copy link
Collaborator

These classes are no longer present in the new smart-pointer based AST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexanderViand @pjattke