-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): handle response content types #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 21 24 +3
Lines 230 283 +53
Branches 24 31 +7
=====================================
+ Hits 230 283 +53
Continue to review full report at Codecov.
|
matchPath('/static/:dir'), | ||
matchType('GET'), | ||
map(req => req.params!.dir as string), | ||
switchMap(readFile(__dirname + './../../docs/assets')), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of putting this path in some const
and maybe you could use path.resolve
here :D ?
PR Type
What kind of change does this PR introduce?
What is the current behavior?
responseHandler
tries toJSON.stringify()
every outgoing response.responseHandler
doesn't detect mime-types automaticallyIssue Number: #33
What is the new behavior?
fileReader
content-type
based on provided bodymarbles.spec-util
to commonutil
foldermock-fs
,mime
andfile-type
packagesDoes this PR introduce a breaking change?