Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-intrusive MFA token collection #11

Open
marceloboeira opened this issue Apr 1, 2019 · 0 comments
Open

Non-intrusive MFA token collection #11

marceloboeira opened this issue Apr 1, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@marceloboeira
Copy link
Owner

At this moment, we use stdin/out to both print the Please type your MFA token... and collect the MFA token. That can be intrusive to users that might want to pipe/redirect its output:

awsudo -u production read_consul_logs > logs.txt

If an MFA token needs to be collected, the file output will include the printed stdin:

Please type your MFA token for arn:aws:iam::9999999999:user/bezos: 

MY LOGS

Therefore, we might be better served using /dev/tty.

Reference:

@marceloboeira marceloboeira added bug Something isn't working good first issue Good for newcomers labels Apr 1, 2019
@marceloboeira marceloboeira added this to the v1.0.0 milestone Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant