Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with relative import #17

Closed
marceloFA opened this issue Nov 10, 2020 · 4 comments
Closed

Fix issue with relative import #17

marceloFA opened this issue Nov 10, 2020 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@marceloFA
Copy link
Owner

marceloFA commented Nov 10, 2020

I'd like to replace all relative imports at pycee/with absolute imports as this is a cleaner approach to imports. The only thing stopping me from doing this is that pytest won't recognize the pycee.utils module if I do from utils import foo instead of from .utils import foo

@marceloFA marceloFA added the help wanted Extra attention is needed label Nov 10, 2020
@marceloFA marceloFA self-assigned this Nov 10, 2020
@LeonardoFurtado
Copy link
Collaborator

The only thing stopping me from doing this is that pytest won't recognize the pycee/utils module if I do from utils import foo instead of from .utils import foo

I believe that this happened to me before, I will see if I have any repository with this solved

@LeonardoFurtado
Copy link
Collaborator

LeonardoFurtado commented Nov 13, 2020

can we close this issue? @marceloFA

@marceloFA
Copy link
Owner Author

marceloFA commented Nov 13, 2020

Not right now but very soon. In the next PRs, I'll close this.

@marceloFA
Copy link
Owner Author

Fixed by #28. See c89ca2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants