-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for getContextPropertiesAsync #22
Comments
Hi, |
The work is in progress, see here. Still need to update docs and changelog though, then push to nuget. One thing about logging the POST body: be careful. Once you read the stream, you cannot rewind it for the next middleware (like WebAPI). Recently a person told me they substitute the original stream with a |
Thanks for working on that on such a short delay, and thanks for the heads up. We'll only be implementing that for the QA, front end devs are building new components and sending requests to our API that are sometimes causing issues. Logging those would help us understand what's going wrong when something goes wrong. |
The version 0.5 containing the changes is now released on nuget |
Thanks for the update and sorry for not answering earlier. I took some time off. |
Hi,
As an improvement, it'd be nice to support getContextPropertiesAsync (adding a new parameter).
This way we'd be able to implement custom tracing that reads in the body of a POST request for example.
The impact should be limited to
HttpRequestTrackingMiddleware
(TraceRequest, ctor, props, Invoke) as well asAppBuilderExtension
(UseApplicationInsights).Let me know if you need more information.
The text was updated successfully, but these errors were encountered: