Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pipenv to build the tox test environments. #67

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

marcofavorito
Copy link
Member

Proposed changes

This PR makes tox to use pipenv install --dev to build the test environment from Pipfile.lock.

That would help in running the tests with the fixed dependencies version numbers declared in Pipfile.lock.

Fixes

None.

Types of changes

What types of changes does your code introduce to agents-tac?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

None.

@marcofavorito marcofavorito merged commit 07fda00 into develop Sep 30, 2019
@marcofavorito marcofavorito deleted the fix/deps-versions branch September 30, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant