Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-118467 test fix #69

Closed
wants to merge 1,260 commits into from
Closed

LPS-118467 test fix #69

wants to merge 1,260 commits into from

Conversation

marcosapmf
Copy link
Owner

@marcosapmf marcosapmf commented Aug 4, 2020

brianchandotcom and others added 30 commits August 2, 2020 21:35
The configuration wasn't specifically targetting AlloyEditor, but it was
only generating valid configuation for that editor. As we are now using
CKEditor, those settings were not being properly honored

Additionally, only <a> tags were allowed but no attribute, so in practice
this editor did not support adding links since their href attributes
would've been wiped out on save. This PR addresses this potential bug
by adding a[href] to the allowedContent rule configuration
…mins of other companies

+ SF exceptions & catch and log them to prevent UI error
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@marcosapmf
Copy link
Owner Author

ci:test:sf

@marcosapmf
Copy link
Owner Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5114630ffc0b18c67c7ef03dfd938f18629fefd9

Sender Branch:

Branch Name: LPS-118467
Branch GIT ID: 7a4ccf159b1f6c899c31be8a11f8b8882eefe31c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4378
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:marcosapmf#69
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - marcosapmf > marcosapmf - PR#69 - 2020-08-04[08:12:42]
Spira Jenkins Build:publish-spira-report#5078

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 101 out of 101 jobs passed in 1 hour 54 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f6b864567ee68d87aeec033df56d4c406b381aca

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: db98256ba2c028c92a356e7a9f0ba6e73335294f

ci:test:stable - 21 out of 21 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 101 out of 101 jobs PASSED
101 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@marcosapmf
Copy link
Owner Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#92247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.