Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in "functions" (argument transfer) #5

Closed
FoxRomeo opened this issue Jul 4, 2014 · 4 comments
Closed

bug in "functions" (argument transfer) #5

FoxRomeo opened this issue Jul 4, 2014 · 4 comments

Comments

@FoxRomeo
Copy link

FoxRomeo commented Jul 4, 2014

Hi
the problem is the line
int header_length = functions_names[i].length() + 8;
Even if you would read the rest of the input until end of line, this would result in a normal use like "/led/1" or "/led/0" no argmuents are transfered (as cut the klenth of the function (led=3) and addtional 8 characters (something like /led--------1 would be valid then).

@marcoschwartz
Copy link
Owner

Hi, thanks for bringing up the issue. Will work to fix that for the next release of the library.

@marcoschwartz
Copy link
Owner

Hello, just tested the feature again & it works fine. I think the problem is that you need to follow this syntax to execute a function:

/led?params=0 executes the function (from the documentation)

Let me know if that works & if I can close the issue.

@prologic
Copy link

I can confirm that executing functions also works just fine.

i.e: curl -q -o - http://10.0.0.152/door?params=800

cheers
James

James Mills / prologic

E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au

On Sat, Jul 12, 2014 at 6:24 PM, marcoschwartz notifications@github.com
wrote:

Hello, just tested the feature again & it works fine. I think the problem
is that you need to follow this syntax to execute a function:

/led?params=0 executes the function (from the documentation)

Let me know if that works & if I can close the issue.


Reply to this email directly or view it on GitHub
#5 (comment).

@marcoschwartz
Copy link
Owner

Ok, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants