Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement #48

Closed
pramitchoudhary opened this issue Feb 23, 2017 · 1 comment
Closed

Performance improvement #48

pramitchoudhary opened this issue Feb 23, 2017 · 1 comment

Comments

@pramitchoudhary
Copy link

Based on the benchmarks done here
http://stackoverflow.com/questions/20277982/fastest-pairwise-distance-metric-in-python.
Using scipy.spatial.distance.pdist vs sklearn.metrics.pairwise_distances could help in improving the computation for computing euclidean distance distance. Need to test it out.

@marcotcr
Copy link
Owner

marcotcr commented Mar 1, 2017

I don't think it matters one way or the other, sklearn distance is pretty fast already.
The time spent computing distances is always vastly smaller than the time spending with everything else.
Unless you found a case where the above isn't true, it isn't worth the effort.
Thanks : )

@marcotcr marcotcr closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants