feat: update react-native-skia to 0.1.136

[akinncar]

Upgrades:

• react-native-skia
• react-native-reanimated
• react-native-gesture-handler

Changes:

• Deprecates useDerivedValue in favor of useComputedValue Shopify/react-native-skia#633

Comments

I can't solve this types validation, seems to work for me as expected with @ts-ignore but please help me to solve it, I don't know how this works

Type 'SkiaValue<SkPath | null>' is not assignable to type 'PathDef | SkiaValue<PathDef>'.
  Type 'SkiaValue<SkPath | null>' is not assignable to type 'SkiaValue<PathDef>'.
    Type 'SkPath | null' is not assignable to type 'PathDef'.
      Type 'null' is not assignable to type 'PathDef'.ts(2322)

https://github.com/margelo/react-native-graph/compare/main...akinncar:feat/update-skia?expand=1#diff-cfb3f852e9829282d769b73218a60d92f55779488387a3333b1c5717365419e9R246

[mrousavy]

Thanks Akinn! PR looks good to me, just 2 minor changes for the from value that can't be null

[mrousavy]

straightLine can never be null, so this can be removed

[akinncar]

interpolate now can return null
interpolate type: (method) SkPath.interpolate(end: SkPath, weight: number): SkPath | null
so when you assign interpolate result to from, it can be null
https://github.com/margelo/react-native-graph/pull/31/files/00840df3ff16404aea00355f7092afada7c35c2d#diff-cfb3f852e9829282d769b73218a60d92f55779488387a3333b1c5717365419e9R94

Shopify/react-native-skia#567

[mrousavy]

But straightLine is not using interpolate?

[akinncar]

on declaration, from doesn't need to be SkPath | null, but on second assignment, when we assign interpolate to from

from = from.interpolate(previous.from, interpolateProgress.current)

it can be null


a possible solution is to create another variable but I don't see any difference

[mrousavy]

I see, hmm this is a bit weird. We could do

from = from.interpolate(previous.from, interpolateProgress.current) ?? from

But that's weird either way. I got your point now

[mrousavy]

Does the point still move correctly with this PR?

I'm seeing this:

Screen.Recording.2022-07-20.at.11.59.37.mov

[gtokman]

@mrousavy Someone filed an issue for that here #26 (comment)

[akinncar]

Does the point still move correctly with this PR?

Fixed on latest commit

but a comment about it: on the first press on the graph, the circle starts in last position, so if is your first press after opening the app, the point will show on 0/0
It's not related to this PR since it's happening on main branch as well
https://user-images.githubusercontent.com/42688281/180664840-8ae6c55c-6523-4f30-abe7-fdb596c3e109.mp4

UPDATE:

Fixed here #32

[mrousavy]

Awesome, thank you Akinn! ❤️

[HasanBingolbali]

is it now fully compatible with react-native-Skia 0.1.136? @mrousavy @akinncar