Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all parseFloat references with BigNumber lib #173

Closed
jordajm opened this issue Apr 28, 2021 · 0 comments
Closed

Replace all parseFloat references with BigNumber lib #173

jordajm opened this issue Apr 28, 2021 · 0 comments
Assignees
@zeta-o

Comments

@jordajm
Copy link
Collaborator

jordajm commented Apr 28, 2021

parseFloat() only has ~10-12 digits of precision
but we need 18 in eth. Refer to other implementations of the BigNumber in the code base to replace all parseFloat()'s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeta-o zeta-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zeta-o @jordajm @cryptobegod @sirmoremoney