Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component - Accordion #1687

Closed
ti10le opened this issue Jan 25, 2022 · 8 comments · Fixed by #2915
Closed

Component - Accordion #1687

ti10le opened this issue Jan 25, 2022 · 8 comments · Fixed by #2915
Assignees
@sarahgm
Labels
status:ready Ready for development type:feature New feature or component

Comments

@ti10le
Copy link
Contributor

ti10le commented Jan 25, 2022 •
edited by sebald
Loading

Description

Accordion component to display some information by click on the main part of the accordion

Context

We need this component to make the Design System more complete and to support some use cases with n accordion.

Use Cases

In the new Checkout to click on Checkbox/Radio/Arrow and display information.

Consequences

Accordion can be used from marigold and does not have to be built by yourself.
@ti10le ti10le added type:feature New feature or component status:rfc New issue that requires discussion and finalization labels Jan 25, 2022
@sebald sebald added status:blocked Work is blocked, see comments and removed status:rfc New issue that requires discussion and finalization labels Jan 28, 2022
@sebald
Copy link
Member

sebald commented Jan 28, 2022

react-aria support is only in alpha

@github-actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@sebald
Copy link
Member

sebald commented Sep 28, 2022

Superseeded by #2388

@sebald sebald closed this as completed Sep 28, 2022
@sarahgm sarahgm reopened this Mar 27, 2023
@sarahgm sarahgm added status:ready Ready for development and removed status:blocked Work is blocked, see comments status:stale labels Mar 27, 2023
@sarahgm sarahgm self-assigned this Mar 27, 2023
@sarahgm
Copy link
Member

sarahgm commented Mar 27, 2023 •
edited
Loading

some help:

@sarahgm
Copy link
Member

sarahgm commented Mar 28, 2023

@sebald not cool adobe/react-spectrum#1989

@sarahgm
Copy link
Member

sarahgm commented Mar 30, 2023 •
edited
Loading

disabledKeys/expandedKeys not supported ??

@sarahgm
Copy link
Member

sarahgm commented Mar 31, 2023 •
edited
Loading

Notes:

  • should our component also marked as beta?
  • right now only defaultExpandedKeys are allowed
  • no disable
  • no special styles
  • also warning which says <Item> with non-plain text contents is unsupported by type to select for accessibility. Please add a textValue prop. :S

something I don't thought of @sebald

@sarahgm sarahgm mentioned this issue Apr 4, 2023
Merged
@sebald sebald mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarahgm sarahgm

Labels
status:ready Ready for development type:feature New feature or component
Projects
📝 Planning Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: new Accordion Component marigold-ui/marigold
3 participants
@sebald @sarahgm @ti10le