fix: fix keyboard controls with carousel #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
previously approved these changes
Mar 9, 2024
Comment on lines
+107
to
+115
| onKeyDown={(e) => { | ||
| // If the target is from a marimo element, stop propagation | ||
| if ( | ||
| e.target instanceof HTMLElement && | ||
| e.target.tagName.toLocaleLowerCase().startsWith("marimo-") | ||
| ) { | ||
| e.stopPropagation(); | ||
| } | ||
| }} |
There was a problem hiding this comment.
Could we do this with onMouseDown too and then re-enable simulateTouch=True?
There was a problem hiding this comment.
i just tried - got pretty close. it works with sliders, but not with altair, so lets just keep it off
mscolnick
force-pushed
the
ms/fix-carousel-keyboard
branch
from
fd46ad6
to
4c2d659
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mo.ui.code_editor) from moving the carouselFixes #923