@close => .destroy (coffeescript)

[ronen]

for code in which a view has a method to close (now destroy itself), the coffeescript might have looked like:

  goAway:  ->
       @close()

and upgrade.py proposes to replace this with:

  goAway:  ->
       .destroy()

rather than:

 goAway: ->
      @destroy()

[vinnymac]

I can confirm this happens. It occurs every time @close() was called inside of a function.

[jasonLaster]

Hey @vinnymac, @ronen - mind investigating a fix for this. I'm not currently doing any coffeescript, so i don't think i'll be able to put too much time into in the near future.

[samccone]

hey guys, yeah this tool "kinda" works for coffeescript, I think if we wanted to really support coffeescript we would need a new matcher / replacement file. If someone is interested in taking a stab obviously @jasonLaster and I have your back :)

[ronen]

@jasonLaster, yeah I'd love to but sadly I doubt I'll get a chance any time soon.

@samccone it's been a month since I did my upgrade, but AFAI can remember it actually worked pretty well on all my coffeescript, and this issue was the only significant hitch I encountered.

In any case, even despite this fairly minor issue, huge kudos for making the automated upgrade script! (Not to mention for making Marionette itself :)

[samccone]

👍 👍