Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different list for findmarker function #100

Open
angkoomin opened this issue May 12, 2022 · 1 comment
Open

Different list for findmarker function #100

angkoomin opened this issue May 12, 2022 · 1 comment

Comments

@angkoomin
Copy link

angkoomin commented May 12, 2022

Hi there,

I'm trying to do a DEG between groups. I applied these two codes:

Code 1:
marker.genes.cluster <- findMarkers(cdScFiltAnnot_Luminal, groups = cdScFiltAnnot_Luminal$Tissue_Zone, pval.type = "all", BPPARAM = bpp)

Code 2:
marker.genes.cluster.up <- findMarkers(cdScFiltAnnot_Luminal, groups = cdScFiltAnnot_Luminal$Tissue_Zone, pval.type = "all", lfc = 0.5, direction = "up", BPPARAM = bpp)

I'm getting a very different list of upregulated genes for both as below. This is the gene list in descending order of LFC for code 1:
image

And code 2:
image

I was wondering if someone can help to explain why I'm getting 2 very different list as I thought the 'direction' and 'lfc' is to help to filter rather than give a very different list. Please help as it will determine which code to use for further downstream analysis.

Thanks

@PeteHaitch
Copy link
Contributor

It looks like the function is doing exactly what you're telling it to do.
With your second function call, you're saying "prioritise genes that have a logFC > 0.5 (lfc = 0.5 and direction = "up") in all pairwise comparisons (pval.type = "all").
There aren't many genes that satisfy those conditions.
But eyeballing the first list, those genes include: ZFP36, CEBPD, DUSP1, NR4A1, CYP1B1, ZFP36L2, KLF6, ..., which are exactly the top hits in the second list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants