Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to angular 6 and new rxjs #163

Open
behroozbc opened this issue Jul 21, 2018 · 6 comments
Open

add support to angular 6 and new rxjs #163

behroozbc opened this issue Jul 21, 2018 · 6 comments

Comments

@behroozbc
Copy link

hi
I use angular 6
I cant run your package I have rxjs error
please update your package

@jorgeemherrera
Copy link

Yes, please, me either run it.

@PascalHonegger
Copy link

Duplicate of #156 => I created a fork (of a fork...) which has the minimal changes required for angular 6 to run (https://github.com/PascalHonegger/ng-datatable - https://www.npmjs.com/package/@pascalhonegger/ng-datatable). We use this version for our project and were able to get rid of the rxjs-compat package. I'm also happy to keep it updated / merged wherever an active version of this package lives.

@pumano
Copy link

pumano commented Feb 19, 2020

@PascalHonegger love your fork, but you don't have issues in your fork, so I write here :) Would love if you add support for angular 9, because since angular 9 your fork @pascalhonegger/ng-datatable not working for production build:

ERROR in node_modules/@pascalhonegger/ng-datatable/lib/src/DataTableModule.d.ts:1:22 - 
error NG6002: Appears in the NgModule.imports of TasksModule, but could not be resolved to an NgModule class

1 export declare class DataTableModule {

@PascalHonegger
Copy link

@pumano Appreciate your comment! I got an Angular 9 version running locally yesterday, will try to publish it today if testing goes smoothly. Had to re-do the whole build / test pipeline using Angluar-CLI, which was a pain.
(And issues have been enabled on the repo 😉)

@PascalHonegger
Copy link

PascalHonegger commented Feb 19, 2020

@pumano Published with version 9.0.1 of @pascalhonegger/ng-datatable, feel free to open an issue in case it isn't working. I tried my best, but with such a massive change in build pipeline it would be a miracle if everything worked first try.

@pumano
Copy link

pumano commented Feb 20, 2020

@PascalHonegger thanks! I will try today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants