Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url not detected correctly #79

Closed
BusinessDuck opened this issue Nov 13, 2019 · 1 comment
Closed

Url not detected correctly #79

BusinessDuck opened this issue Nov 13, 2019 · 1 comment

Comments

@BusinessDuck
Copy link

Example url :
https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS))&fields=change(comment)

Matched result:

https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS))

Missing part:
&fields=change(comment)

@puzrin
Copy link
Member

puzrin commented May 18, 2020

Seems dupe of #23. Current implementation does not allow easy handle of nested patterns. Also, we can not blind allow multiple ))) due false positives for such case:

(text https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS)))

There are no way to detect where to stop without true nested parser.

I've added reference to #23 and closing this as dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants